Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding services no longer works #1296

Closed
alexdima opened this issue Jan 31, 2019 · 2 comments
Closed

Overriding services no longer works #1296

alexdima opened this issue Jan 31, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone

Comments

@alexdima
Copy link
Member

Extracted from #291 (comment)

@alexdima alexdima added this to the On Deck milestone Jan 31, 2019
@alexdima alexdima self-assigned this Jan 31, 2019
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 31, 2019
@alexdima alexdima modified the milestones: On Deck, February 2019 Mar 4, 2019
@alexdima
Copy link
Member Author

alexdima commented Mar 5, 2019

There is no regression. Overriding services works fine. e.g.

var openerService = {
	open: function() {
		alert(`open called!` + JSON.stringify(arguments));
	}
};

var model = monaco.editor.createModel('http://www.microsoft.com', 'plaintext');

var editor = monaco.editor.create(document.getElementById('container'), {
	model: model,
	glyphMargin: true,
	renderWhitespace: true
}, { openerService: openerService });

@alexdima alexdima closed this as completed Mar 5, 2019
@frankLife
Copy link

frankLife commented Mar 8, 2019

@alexandrudima It's great ! Besides it can give more information or documentation about overriding services?

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

2 participants