-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overriding services no longer works #1296
Labels
Milestone
Comments
alexdima
added
bug
Issue identified by VS Code Team member as probable bug
important
Issue identified as high-priority
labels
Jan 31, 2019
There is no regression. Overriding services works fine. e.g. var openerService = {
open: function() {
alert(`open called!` + JSON.stringify(arguments));
}
};
var model = monaco.editor.createModel('http://www.microsoft.com', 'plaintext');
var editor = monaco.editor.create(document.getElementById('container'), {
model: model,
glyphMargin: true,
renderWhitespace: true
}, { openerService: openerService }); |
@alexandrudima It's great ! Besides it can give more information or documentation about overriding services? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Extracted from #291 (comment)
The text was updated successfully, but these errors were encountered: