Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update Swift language specification to version 5.5 #2854

Closed
2 tasks done
philipturner opened this issue Dec 26, 2021 · 5 comments
Closed
2 tasks done
Labels
feature-request Request for new features or functionality

Comments

@philipturner
Copy link
Contributor

philipturner commented Dec 26, 2021

Context

  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description

Syntax coloring specifications for Swift (swift.ts) are out of date and appear to be from Swift 4 (the most recent version is 5.5). For example, here is a short list of keywords not indexed:

  • @differentiable(reverse)
  • async
  • @escaping
  • @inlinable
  • await
  • associatedtype
  • @unchecked
  • rethrows

A list of language keywords can be found here, although the keywords that start with @ are not listed. There are numerous @ keywords, and it isn't feasible to include all of the ones starting with underscores. However, the ones that start with alphabetic characters should be possible to tabulate.

Monaco is the engine behind Google Colab's syntax coloring, and I am concerned because my effort to revive Swift support is negatively impacted by incorrect syntax coloring. Colab is currently restricted to Monaco 0.27.0, so it won't benefit from this correction immediately (the currently version is 0.31.0). Since 0.27.0 was released a few months ago, I expect Google to update to a newer version in the time frame of a few months.

@philipturner philipturner added the feature-request Request for new features or functionality label Dec 26, 2021
@hediet hediet self-assigned this Jan 3, 2022
@hediet
Copy link
Member

hediet commented Jan 3, 2022

Thanks for the PR! Can you fix the CI issue? (prettier)

@philipturner
Copy link
Contributor Author

philipturner commented Jan 3, 2022

@hediet I don't know how exactly to fix the issue. Could you give me a pointer to thorough instructions for how to do it?

@hediet
Copy link
Member

hediet commented Jan 3, 2022

Please use prettier to format the files you touched.

@philipturner
Copy link
Contributor Author

philipturner commented Jan 3, 2022 via email

@hediet
Copy link
Member

hediet commented Jan 3, 2022

You should be able to simply run npm run prettier in the root directory of this repo.

@hediet hediet removed their assignment Mar 9, 2023
@hediet hediet closed this as completed Mar 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants