Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense suggestions are not accessible to a screen reader #425

Closed
jayspadie opened this issue Apr 21, 2017 · 5 comments
Closed

IntelliSense suggestions are not accessible to a screen reader #425

jayspadie opened this issue Apr 21, 2017 · 5 comments
Assignees
Milestone

Comments

@jayspadie
Copy link
Member

monaco-editor version: 0.8.3
Browser: Any
OS: Windows 10

During Accessibility testing, it was found that IntelliSense suggestions are not read correctly by a screen reader. Using Narrator with Edge, nothing is read while arrowing up/down the selections. Using NVDA with Chrome or Firefox, the current line of code is repeated while arrowing through each suggestion instead of the suggestion itself, as shown below from the Monaco playground using NVDA with Chrome.

image

@egamma
Copy link
Member

egamma commented Apr 24, 2017

// fyi @chrisdias

@chrisdias
Copy link
Member

Related to microsoft/vscode#3787

@chrisdias chrisdias added this to the May 2017 milestone May 18, 2017
@alexdima
Copy link
Member

alexdima commented Jun 2, 2017

The root problem here is that in the monaco editor we don't have an aria-alert dom node configured. I am not sure if we are allowed to have multiple aria-alert dom nodes on a single page. i.e. what should happen if one host instantiates two monaco editors on a single page, should we create a single aria-alert dom node or should we create two. Should this be configurable such that we reuse the aria-alert dom node of the host...

@alexdima alexdima self-assigned this Jun 2, 2017
@jayspadie
Copy link
Member Author

It is not uncommon for us to have multiple aria-live="polite" (with aria-atomic="true") divs on a page, and they seem to work. We also have cases of reusing the same aria-live div from multiple controls. I am not aware of any restrictions with having more than one.

@alexdima
Copy link
Member

alexdima commented Jun 28, 2017

@jayspadie In your experience, does role="alert" work on Narrator + Edge ? I could not find any way to make Narrator read an alert. (see #481)

e.g. from https://www.w3.org/TR/WCAG20-TECHS/ARIA19.html

Nevermind. A restart later ... Narrator started reading role="alert" content...

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants