Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] when 0.53 monaco-editor version will be released with the vulnerability fix? #4738

Closed
2 tasks done
Andrevwvm opened this issue Nov 5, 2024 · 10 comments
Closed
2 tasks done
Assignees

Comments

@Andrevwvm
Copy link

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

Please answer the question: Do you happen to know when 0.53 monaco-editor version will be released with the vulnerability fix?
#4692 (comment)

Monaco editor has CVE which is fixed and not released for a quite some time for now.

Actual (Problematic) Behavior

No response

Expected Behavior

No response

Additional Context

No response

@Andrevwvm
Copy link
Author

Hi @joaomoreno, could you please provide us with some information about the release date? Thanks in advance for your help

@rogerhendriks
Copy link

https://www.npmjs.com/package/monaco-editor is still 0.52.0
@rzhao271 @mjbvz @joaomoreno can someone please give us a heads up?
We are desperately awaiting this as all our dependency checks fail, the fix is there and milestone closed.
Thanks!

@BerendvanhoekFenetre
Copy link

Hi @rzhao271 @mjbvz @joaomoreno

As there is no reply in 3 weeks regarding the release date, can we please get an update?
Thanks!

@acherkashin
Copy link

acherkashin commented Nov 26, 2024

At least, knowing the approx date would be helpful

@rogerhendriks
Copy link

Hi @rzhao271 @mjbvz @joaomoreno

As there is no reply in 3 weeks regarding the release date, can we please get an update? Thanks!

@aiday-mar @hediet

@dreamofdoc
Copy link

Do you know if new patch update release includes this fix, or we have to wait for minor release (0.53)?

@acherkashin
Copy link

@dreamofdoc
Copy link

@acherkashin Oh I see, thank you!

@blutorange
Copy link
Contributor

blutorange commented Dec 10, 2024

Just from the diff between 0.52.2 and 0.52.0 it wasn't clear to me if the fix is really included. But if you take a look at

http://unpkg.com/monaco-editor@0.52.2/esm/vs/base/browser/dompurify/dompurify.js

you can see the version DOMPurify 3.1.7. And according to CVE-2024-45801, it's fixed with DOMPurify 3.1.3. So it really should be fixed now.

@hediet
Copy link
Member

hediet commented Dec 12, 2024

Fixed in 0.52.2 (https://github.com/microsoft/monaco-editor/blob/release/0.52/CHANGELOG.md#0521).

Just from the diff between 0.52.2 and 0.52.0 it wasn't clear to me if the fix is really included. But if you take a look at

This is because the monaco editor is built from the VS Code sources, which we reference by its commit hash.

https://nvd.nist.gov/vuln/detail/CVE-2024-45801

That CVE is about "Inefficient Regular Expression Complexity", which does not play a role for the monaco-editor.
In any case, the warnings should disappear now, as the latest stable monaco editor now ships with a recent version of DOMPurify.

@hediet hediet closed this as completed Dec 12, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants