[BUG] getColumns not escaping Wildcards

[probert94]

Driver version

Version 7.3.1 or later

SQL Server version

SQL Server 2017

Client Operating System

Windows 10 x64

JAVA/JVM version

OpenJDK 1.8.0_202

Problem description

1. Expected behaviour:
   I have a table with a column ID_Article.
   When calling getColumns with ID\_Article as col Parameter, it should return the description of table column ID_Article .

2. Actual behaviour:
   Since version 7.3.1 it does not seem to find the column anymore, as it does not escape the _ correctly.

3. Error message/stack trace:
   No error is thrown, it just does not find the column.

4. Any other details that can be helpful:
   The method EscapeIDName states, that \_n will be mapped to '[_]n' as the SQL-Server expects this syntax. However, this mapping does not seem to occur anymore.
   The bug was probably introduced by Fix | Align DatabaseMetadata.getColumns with JDBC 4.3 Specifications #1016.
   Also [BUG] regression with 7.4.1 (against 7.2.2) #1134 might be related to this.

[peterbae]

Hi @Springrbua, thanks for contacting us. I've identified the issue and I'm testing my fix. As soon as the internal testings are done, I'll create a PR and provide you with a custom jar that contains my fix.

[peterbae]

Hi @Springrbua, @mprins, I've made a PR that fixes this issue. I've attached the driver jars with the fix in them (for Java 8/12), so if you have time, please try these and confirm if the fix is good. Thanks!

github-1136-fix.zip

[probert94]

@peterbae Thank you very much, the patched driver fixed the issue for me.

[dqmdev]

When will MS release the build to customers?

In other words, when will the successor to 7.4.1 be announced at

https://techcommunity.microsoft.com/t5/SQL-Server/bg-p/SQLServer/label-name/SQLServerDrivers

[peterbae]

We're aiming to release the next preview version of the driver by the end of this month, and it will include this fix.

[mprins]

I had a chance to test this today, I can not reproduce the problem with the attached, patched driver, even though I don't have columns with underscores, but do have tables with underscores, but that also seems to be adressed in #1138

[ulvii]

#1138 merged.