Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify depracted Lob public constructors #185

Closed
marschall opened this issue Mar 10, 2017 · 2 comments
Closed

Clarify depracted Lob public constructors #185

marschall opened this issue Mar 10, 2017 · 2 comments
Assignees
@AfsanehR-zz

Comments

@marschall
Copy link
Contributor

Both SQLServerClob and SQLServerBlob have deprecated public constructors. They are not used by the driver itself. I assume they are there to avoid breaking clients. I assume Connection#createClob and Connection#createBlob should be used instead. If that's true then it would be nice if this was documented in an @deprecated Javadoc tag and possibly in some kind of versioning policy on when the constructors will be removed.
@v-nisidh v-nisidh assigned v-nisidh and AfsanehR-zz and unassigned v-nisidh Mar 13, 2017
@v-nisidh v-nisidh added this to the Next Tasks milestone Mar 13, 2017
@AfsanehR-zz
Copy link
Contributor

@marschall Thank you for pointing out this . We will update the javadocs for these constructors. But for now, we will not be removing the deprecated ones.

@AfsanehR-zz AfsanehR-zz mentioned this issue Mar 28, 2017
Merged
@AfsanehR-zz
Copy link
Contributor

fixed by PR #226.

@v-nisidh v-nisidh removed this from the Next Tasks milestone Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AfsanehR-zz AfsanehR-zz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marschall @AfsanehR-zz @v-nisidh