Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readability and reduce brittleness of Variable Services "bucket" logic #126

Open
corthon opened this issue May 10, 2022 · 2 comments
Assignees
Labels
repo:mu_basecore Issue impacts repo mu_basecore state:backlog In the backlog type:enhancement New feature or pull request

Comments

@corthon
Copy link
Member

corthon commented May 10, 2022

You can see perhaps the worst offender here:
https://github.com/microsoft/mu_basecore/blob/c4d0d1130454b3e5051bb601c707234e3a91713a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c#L2185

But the idea is to wrap each of these tests in a descriptive macro or function so that it's more readable AND we don't have to change multiple places if we ever change the logic (like adding a new PCD).

Example: WillVarExceedHwErrQuota( VarSize );, or something like that.

@corthon corthon added type:enhancement New feature or pull request repo:mu_basecore Issue impacts repo mu_basecore labels May 10, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Nov 29, 2022
@makubacki makubacki added the state:backlog In the backlog label Nov 29, 2022
@github-actions github-actions bot removed the state:stale Has not been updated in a long time label Nov 29, 2022
@abrahamdestiny
Copy link

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo:mu_basecore Issue impacts repo mu_basecore state:backlog In the backlog type:enhancement New feature or pull request
Projects
None yet
Development

No branches or pull requests

3 participants