Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we remove src/subs? #20

Open
joshgav opened this issue May 5, 2017 · 2 comments
Open

can we remove src/subs? #20

joshgav opened this issue May 5, 2017 · 2 comments

Comments

@joshgav
Copy link
Contributor

joshgav commented May 5, 2017

Now that microsoft/ApplicationInsights-node.js#235 is pending?

cc @MSLaguana

@MSLaguana
Copy link
Member

That should be fine, but I'd defer to @OsvaldoRosado and @mike-kaufman since they are somewhat helpful as a validation that AI isn't broken (as in, if they compile, AI should work)

@mike-kaufman
Copy link
Contributor

they are somewhat helpful as a validation that AI isn't broken (as in, if they compile, AI should work)

I'll let AI guys make a call on this.

Naturally, we need something stronger than compile-time checks to confirm AI is not broken.

That said, compile-time checks like this are useful. My thinking is we'll eventually have a "test" folder that will include a "test client" that uses & validates the system through exposed public APIs here. We're not there today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants