Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3.0 induce breaking changes in some packages of the ecosystem #91

Closed
Zer0xxxx opened this issue Jun 24, 2024 · 10 comments
Closed

v3.3.0 induce breaking changes in some packages of the ecosystem #91

Zer0xxxx opened this issue Jun 24, 2024 · 10 comments

Comments

@Zer0xxxx
Copy link

Zer0xxxx commented Jun 24, 2024

Hello!
I've noticed that some packages (for example: wireit) have been broken with the release of the v3.3.0 of jsonc-parser.

Related to: google/wireit#1111

@rijkvanzanten
Copy link

I've been seeing the same behavior starting 3.3.0. In my case it's through the use of rollup-plugin-esbuild, but the symptom and results are the same.

file:///{{REDACTED}}/node_modules/rollup-plugin-esbuild/dist/index.mjs:11
import { parse } from "jsonc-parser";
         ^^^^^
SyntaxError: Named export 'parse' not found. The requested module 'jsonc-parser' is a CommonJS module, which may not support all module.exports as named exports.

@jakebailey
Copy link
Member

See also:

@aeschli
Copy link
Contributor

aeschli commented Jun 24, 2024

Fix is on the way, I'll revert the change.

@jakebailey
Copy link
Member

3.3.1 has brought things back to the way they were before:

@Zer0xxxx
Copy link
Author

3.3.1 has brought things back to the way they were before:

* https://arethetypeswrong.github.io/?p=jsonc-parser%403.3.1

* https://publint.dev/jsonc-parser@3.3.1

Oh my god, this is AWESOME, thank you!
Can I remove the overrides in my package.json (using pnpm) and check for you if all works again as expected in my project?

@jakebailey
Copy link
Member

Yes, just avoid 3.3.0.

@Zer0xxxx
Copy link
Author

Zer0xxxx commented Jun 24, 2024

Yes, just avoid 3.3.0.

It's fine for me, using wireit, all works again as expected, thank you!

@Zer0xxxx
Copy link
Author

Hello @jakebailey
Should we close this issue as resolved?

@jakebailey
Copy link
Member

Sure (I'm not on the team that works on this package so I can't do it).

@Zer0xxxx
Copy link
Author

Zer0xxxx commented Jun 27, 2024

Sure (I'm not on the team that works on this package so I can't do it).

Okay, let's close this!
Feel free to reopen this issue if you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants