Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import winpty master #296

Closed
Eugeny opened this issue May 10, 2019 · 1 comment · Fixed by #297
Closed

Import winpty master #296

Eugeny opened this issue May 10, 2019 · 1 comment · Fixed by #297
Labels
help wanted Issues identified as good community contribution opportunities windows

Comments

@Eugeny
Copy link
Contributor

Eugeny commented May 10, 2019

winpty master includes the fix for Ctrl-C behaviour in PowerShell, but they haven't released in two years.

Would you consider importing the fresh winpty source into node-pty? It proved to be quite stable in Terminus, and I'm currently keeping a node-pty fork with the updated winpty inside
@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities windows labels May 10, 2019
@Tyriar
Copy link
Member

Tyriar commented May 10, 2019

Sure, open to PRs, we just have a copy of the whole winpty project in deps atm. If you want to do this could you also include references to relevant changes/commits in the winpty project?

@Eugeny Eugeny mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues identified as good community contribution opportunities windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated winpty Eugeny/node-pty
2 participants
@Eugeny @Tyriar