Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawn-helper hangs when nofile limit is large #578

Closed
pandada8 opened this issue Feb 4, 2023 · 1 comment
Closed

spawn-helper hangs when nofile limit is large #578

pandada8 opened this issue Feb 4, 2023 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@pandada8
Copy link

pandada8 commented Feb 4, 2023

Environment details

  • OS: Linux
  • OS version: 6.1.9-arch1-1
  • node-pty version: 0.11.0-beta27

Issue description

spawn-helper seems traversing fd to nofile and close them. When running on a Linux system configured with high nofile limit (in this case, 2147483583), this takes a long time and cause vscode to popup pty host process is unresponsive notifications.

Maybe /proc/self/fd can be used to get all fds to be closed ?
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label May 23, 2023
@jonah-iden jonah-iden mentioned this issue Oct 16, 2024
Open
@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2024

/duplicate #657

@Tyriar Tyriar closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @pandada8