add test

Author: chkeita

src/ApiService/ApiService/OneFuzzTypes/Responses.cs

@@ -103,7 +103,7 @@ public record JobResponse(
     StoredUserInfo? UserInfo,
     [property: JsonPropertyName("Timestamp")] // must retain capital T for backcompat
     DateTimeOffset? Timestamp,
-    IEnumerable<int>? AdoBugIds
+    IEnumerable<int> AdoBugIds
 
 // not including UserInfo from Job model
 ) : BaseResponse() {
@@ -117,7 +117,7 @@ public static JobResponse ForJob(Job j, IEnumerable<IJobTaskInfo>? taskInfo, IEn
             TaskInfo: taskInfo,
             UserInfo: j.UserInfo,
             Timestamp: j.Timestamp,
-            AdoBugIds: adoBugIds
+            AdoBugIds: adoBugIds ?? new List<int>()
         );
     public DateTimeOffset? StartTime => EndTime is DateTimeOffset endTime ? endTime.Subtract(TimeSpan.FromHours(Config.Duration)) : null;
 }

src/ApiService/IntegrationTests/Fakes/TestAdoNotificationEntryOperations.cs

@@ -0,0 +1,8 @@
+using Microsoft.Extensions.Logging;
+using Microsoft.OneFuzz.Service;
+namespace IntegrationTests.Fakes;
+
+public sealed class TestAdoNotificationEntryOperations : AdoNotificationEntryOperations {
+    public TestAdoNotificationEntryOperations(ILogger<AdoNotificationEntryOperations> log, IOnefuzzContext context)
+        : base(log, context) { }
+}

src/ApiService/IntegrationTests/Fakes/TestContext.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http;
 using Microsoft.Extensions.Caching.Memory;
@@ -65,9 +66,28 @@ public Async.Task InsertAll(params EntityBase[] objs)
                 InstanceConfig ic => ConfigOperations.Insert(ic),
                 Notification n => NotificationOperations.Insert(n),
                 Webhook w => WebhookOperations.Insert(w),
+                AdoNotificationEntry ado => AdoNotificationEntryOperations.Insert(ado),
                 _ => throw new NotSupportedException($"You will need to add an TestContext.InsertAll case for {x.GetType()} entities"),
             }));
 
+    public Async.Task InsertAll(IEnumerable<EntityBase> objs)
+        => Async.Task.WhenAll(
+        objs.Select(x => x switch {
+            Task t => TaskOperations.Insert(t),
+            Node n => NodeOperations.Insert(n),
+            Pool p => PoolOperations.Insert(p),
+            Job j => JobOperations.Insert(j),
+            JobResult jr => JobResultOperations.Insert(jr),
+            Repro r => ReproOperations.Insert(r),
+            Scaleset ss => ScalesetOperations.Insert(ss),
+            NodeTasks nt => NodeTasksOperations.Insert(nt),
+            InstanceConfig ic => ConfigOperations.Insert(ic),
+            Notification n => NotificationOperations.Insert(n),
+            Webhook w => WebhookOperations.Insert(w),
+            AdoNotificationEntry ado => AdoNotificationEntryOperations.Insert(ado),
+            _ => throw new NotSupportedException($"You will need to add an TestContext.InsertAll case for {x.GetType()} entities"),
+        }));
+
     // Implementations:
 
     public IMemoryCache Cache { get; }

src/ApiService/IntegrationTests/JobsTests.cs

@@ -226,4 +226,30 @@ await Context.InsertAll(
         Assert.Equal(task.Config.Task.Type, returnedTasks[0].Type);
 
     }
+
+    [Fact]
+    public async Async.Task Get_CanFindSpecificJobWithBugs() {
+        var taskConfig = new TaskConfig(_jobId, new List<Guid>(), new TaskDetails(TaskType.Coverage, 60));
+
+        var random = new Random();
+        var bugs = Enumerable.Range(1, 100).Select(i => random.Next(0, 100)).Distinct().Select(i => new AdoNotificationEntry(_jobId, i, $"test_i")).ToList();
+        await Context.InsertAll(bugs);
+        await Context.InsertAll(
+            new Job(_jobId, JobState.Stopped, _config, null),
+            new Task(_jobId, Guid.NewGuid(), TaskState.Running, Os.Windows, taskConfig)
+            );
+
+        var func = new Jobs(Context, LoggerProvider.CreateLogger<Jobs>());
+
+        var ctx = new TestFunctionContext();
+        var result = await func.Run(TestHttpRequestData.FromJson("GET", new JobSearch(JobId: _jobId, WithBugs: true)), ctx);
+        Assert.Equal(HttpStatusCode.OK, result.StatusCode);
+
+        var response = BodyAs<JobResponse>(result);
+        Assert.Equal(_jobId, response.JobId);
+        Assert.NotNull(response.TaskInfo);
+        var returnedBugs = response.AdoBugIds.ToList();
+        Assert.NotEmpty(returnedBugs);
+        Assert.Equal(bugs.Select(x => x.Id), returnedBugs);
+    }
 }