Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Increase default level of feedback/confirmation in dry-run of destructive commands #1282

Open
stishkin opened this issue Sep 24, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@stishkin
Copy link
Contributor

stishkin commented Sep 24, 2021

When running onefuzz jobs containers delete <job-id> the --dryrun flag does not indicate whether the containers have already been deleted. It could be useful if it did. This may require tracking more container metadata, or making additional queries.

AB#35966

@mgreisen
Copy link
Contributor

The level of feedback provided by the fix for #1264 is enough for now.

@ranweiler
Copy link
Member

Reopening for discussion, since this feature request wasn't actually addressed.

@ranweiler
Copy link
Member

Motivating use case from an end-user:

My goal is understanding: "what has already been deleted?".

My steps were:

  1. I wanted to remove the containers associated with a job id.
  2. I ran --dryrun to see what would get deleted.
  3. That looked ok, so I ran delete without --dryrun.
  4. Then I re-ran --dryrun to see what the status was. There it was again printing "would be deleted", suggesting that the containers had not, in fact, been deleted.
  5. So I re-ran delete without --dryrun, and this time it did print "already deleted", suggesting that the containers had, verily, been deleted already.
  6. And there I understood that --dryrun does not check the status of the containers before listing them as deletable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants