Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Move call to check_access to call_if #1465

Closed
chkeita opened this issue Nov 18, 2021 · 0 comments · Fixed by #1472
Closed

Move call to check_access to call_if #1465

chkeita opened this issue Nov 18, 2021 · 0 comments · Fixed by #1472
Assignees
@chkeita

Comments

@chkeita
Copy link
Contributor

chkeita commented Nov 18, 2021 •
edited
Loading

Currently this call is made when parsing a request. So no check happens when a request has no parameters.
This needs to be moved to the call_if function that gets called on all request
This is part of the work to implement the access control, not security vulnerability

Originally posted by @chkeita in #1074 (comment)
@chkeita chkeita self-assigned this Nov 18, 2021
@ghost ghost added the Needs: triage label Nov 18, 2021
@chkeita chkeita mentioned this issue Nov 22, 2021
Merged
2 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chkeita chkeita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move call to check_access to call_if chkeita/onefuzz
1 participant
@chkeita