Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Task setup scripts should run with a timeout #1658

Closed
ranweiler opened this issue Feb 16, 2022 · 0 comments · Fixed by #1659
Closed

Task setup scripts should run with a timeout #1658

ranweiler opened this issue Feb 16, 2022 · 0 comments · Fixed by #1659
Assignees
Labels
bug Something isn't working

Comments

@ranweiler
Copy link
Member

ranweiler commented Feb 16, 2022

If a task has a setup script and it hangs, we don't time out until NODE_EXPIRATION_TIME of 1 hour expires, and the node gets reimaged. The error messages around this can be confusing

Instead, have a setup script-specific timeout that defaults to something reasonable. Ideally this would be set per-colocated task set. However, for now, it must never exceed NODE_EXPIRATION_TIME.

@ranweiler ranweiler added the bug Something isn't working label Feb 16, 2022
@ghost ghost added the Needs: triage label Feb 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants