Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Supervisor telemetry not flushed on error #20

Closed
ranweiler opened this issue Sep 22, 2020 · 0 comments · Fixed by #21
Closed

Supervisor telemetry not flushed on error #20

ranweiler opened this issue Sep 22, 2020 · 0 comments · Fixed by #21

Comments

@ranweiler
Copy link
Member

Information

  • Onefuzz version: 1.0
  • OS: Any

Provide detailed reproduction steps (if any)

Create a job (or task) with a target setup script that exits nonzero.

Expected result

Error log telemetry appears in App Insights.

Actual result

It does not appear. This is because we early return in the error path, without flushing error telemetry.

@ranweiler ranweiler linked a pull request Sep 22, 2020 that will close this issue
6 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant