Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Require task-creating clients to relativize to setup directory #2388

Closed
ranweiler opened this issue Sep 13, 2022 · 1 comment
Closed

Require task-creating clients to relativize to setup directory #2388

ranweiler opened this issue Sep 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ranweiler
Copy link
Member

ranweiler commented Sep 13, 2022

Right now, when generating task configs, we prepend certain config parameters with the path prefix setup/ when generating the config. If a client creates a task with target_exe = "my-fuzzer.exe", then config.target_exe == "setup/my-fuzzer.exe". In general, the server expects the client to submit a blob container-relative virtual blob for such config parameters.

Move this responsibility to the client, and require that task creators relativize paths as-needed using the {setup_dir} expansion variable. This expansion will not yet work in general, as described in #2387. As an interim step, have the CLI templates effect the hardcoding that is currently happening server-side.

AB#41312886

@ranweiler ranweiler added the enhancement New feature or request label Sep 13, 2022
@ghost ghost added the Needs: triage label Sep 13, 2022
@ranweiler ranweiler linked a pull request Sep 14, 2022 that will close this issue
@ranweiler
Copy link
Member Author

This is doable, runs into even-worse hardcoding friction in server-side paths where we'd soon need to implement placeholder expansion. See the discussion in #2399.

Closing this for now, since any solution that shifts the burden to the client side really should use variable expansion, and be holistically implemented, which may require more significant changes to the repro VM runtime code.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants