Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

notifications/common.py Render raises bare exceptions #575

Closed
bmc-msft opened this issue Feb 18, 2021 · 0 comments · Fixed by #576
Closed

notifications/common.py Render raises bare exceptions #575

bmc-msft opened this issue Feb 18, 2021 · 0 comments · Fixed by #576
Assignees
@bmc-msft
Labels
bug Something isn't working

Comments

@bmc-msft
Copy link
Contributor

bmc-msft commented Feb 18, 2021 •
edited by mgreisen
Loading

While raising ValueError is reasonable in the context of Render, we should provide context in the exception such that logs include why the exception was raised.

AB#43103045
@bmc-msft bmc-msft added the bug Something isn't working label Feb 18, 2021
@ghost ghost added the Needs: triage label Feb 18, 2021
@bmc-msft bmc-msft self-assigned this Feb 18, 2021
@bmc-msft bmc-msft mentioned this issue Feb 19, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bmc-msft bmc-msft

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add details to exceptions generated during report render failures bmc-msft/onefuzz
2 participants
@stishkin @bmc-msft