allow pools & scalesets set to `shutdown` to `halt` #1104

bmc-msft · 2021-07-22T19:14:08Z

Currently, if a pool or scaleset is set to shutdown, it cannot be set to halt.

While moving from halt to shutdown would cause issues, moving from shutdown to halt is fine.

src/api-service/__app__/onefuzzlib/workers/pools.py

src/api-service/__app__/onefuzzlib/workers/scalesets.py

ghost · 2021-07-23T11:19:29Z

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 1 hour 54 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

allow pools & scalesets set to shutdown to halt

5555892

ranweiler reviewed Jul 22, 2021

View reviewed changes

src/api-service/__app__/onefuzzlib/workers/pools.py Show resolved Hide resolved

src/api-service/__app__/onefuzzlib/workers/scalesets.py Show resolved Hide resolved

src/api-service/__app__/onefuzzlib/workers/scalesets.py Show resolved Hide resolved

ranweiler approved these changes Jul 22, 2021

View reviewed changes

bmc-msft added auto-merge passed-integration-tests labels Jul 23, 2021

ghost merged commit 55366e7 into microsoft:main Jul 23, 2021

ghost locked as resolved and limited conversation to collaborators Aug 22, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow pools & scalesets set to `shutdown` to `halt` #1104

allow pools & scalesets set to `shutdown` to `halt` #1104

bmc-msft commented Jul 22, 2021

ghost commented Jul 23, 2021

allow pools & scalesets set to shutdown to halt #1104

allow pools & scalesets set to shutdown to halt #1104

Conversation

bmc-msft commented Jul 22, 2021

ghost commented Jul 23, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

allow pools & scalesets set to `shutdown` to `halt` #1104

allow pools & scalesets set to `shutdown` to `halt` #1104

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.