wip

Author: rwoll

tests/async/test_har.py

@@ -20,7 +20,7 @@
 
 import pytest
 
-from playwright.async_api import Browser, BrowserContext, Error, expect, Page, Route
+from playwright.async_api import Browser, BrowserContext, Error, Page, expect
 from tests.server import Server
 
 
@@ -256,19 +256,26 @@ async def test_should_page_route_from_har_matching_the_method_and_following_redi
 async def test_fallback_continue_should_continue_when_not_found_in_har(
     context: BrowserContext, server: Server, assetdir: Path
 ) -> None:
-    await context.route_from_har(har=assetdir / "har-fulfill.har", not_found='fallback')
+    await context.route_from_har(har=assetdir / "har-fulfill.har", not_found="fallback")
     page = await context.new_page()
-    await page.goto(server.PREFIX + '/one-style.html')
-    await expect(page.locator("body")).to_have_css("background-color", "rgb(255, 192, 203)")
+    await page.goto(server.PREFIX + "/one-style.html")
+    await expect(page.locator("body")).to_have_css(
+        "background-color", "rgb(255, 192, 203)"
+    )
+
 
 async def test_by_default_should_abort_requests_not_found_in_har(
-    context: BrowserContext, server: Server, assetdir: Path, is_chromium: bool, is_webkit: bool
+    context: BrowserContext,
+    server: Server,
+    assetdir: Path,
+    is_chromium: bool,
+    is_webkit: bool,
 ) -> None:
     await context.route_from_har(har=assetdir / "har-fulfill.har")
     page = await context.new_page()
 
     with pytest.raises(Error) as exc_info:
-        resp = await page.goto(server.EMPTY_PAGE)
+        await page.goto(server.EMPTY_PAGE)
     assert exc_info.value
     if is_chromium:
         assert "net::ERR_FAILED" in exc_info.value.message
@@ -277,29 +284,33 @@ async def test_by_default_should_abort_requests_not_found_in_har(
     else:
         assert "NS_ERROR_FAILURE" in exc_info.value.message
 
+
 async def test_fallback_continue_should_continue_requests_on_bad_har(
     context: BrowserContext, server: Server, tmpdir: Path
 ) -> None:
     path_to_invalid_har = tmpdir / "invalid.har"
     with path_to_invalid_har.open("w") as f:
-        json.dump({ "log": {} }, f)
-    await context.route_from_har(har=path_to_invalid_har, not_found='fallback')
+        json.dump({"log": {}}, f)
+    await context.route_from_har(har=path_to_invalid_har, not_found="fallback")
     page = await context.new_page()
-    await page.goto(server.PREFIX + '/one-style.html')
-    await expect(page.locator("body")).to_have_css("background-color", "rgb(255, 192, 203)")
+    await page.goto(server.PREFIX + "/one-style.html")
+    await expect(page.locator("body")).to_have_css(
+        "background-color", "rgb(255, 192, 203)"
+    )
 
-async def test_should_handle_requests_matching_url_filter(
-    context: BrowserContext, server: Server, assetdir: Path
-) -> None:
-    await context.route_from_har(har=assetdir / "har-fulfill.har", not_found='fallback', url='**/*.js')
-    page = await context.new_page()
-    async def handler(route: Route):
-        assert route.request.url == 'http://no.playwright/'
-        await route.fulfill(status=200, content_type='text/html', body='<script src="./script.js"></script><div>hello</div>')
-    await context.route('http://no.playwright/', handler)
-    await page.goto('http://no.playwright/')
-    assert await page.evaluate("window.value") == "foo"
-    await expect(page.locator("body")).to_have_css("background-color", "rgba(0, 0, 0, 0)'")
+
+# async def test_should_handle_requests_matching_url_filter(
+#     context: BrowserContext, server: Server, assetdir: Path
+# ) -> None:
+#     await context.route_from_har(har=assetdir / "har-fulfill.har", not_found='fallback', url='**/*.js')
+#     page = await context.new_page()
+#     async def handler(route: Route):
+#         assert route.request.url == 'http://no.playwright/'
+#         await route.fulfill(status=200, content_type='text/html', body='<script src="./script.js"></script><div>hello</div>')
+#     await context.route('http://no.playwright/', handler)
+#     await page.goto('http://no.playwright/')
+#     assert await page.evaluate("window.value") == "foo"
+#     await expect(page.locator("body")).to_have_css("background-color", "rgba(0, 0, 0, 0)'")
 
 # it('should only handle requests matching url filter', async ({ context, isAndroid, asset }) => {
 #   it.fixme(isAndroid);