You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using the latest version. This is more of a code smell than a bug.
Context
The setup.py specifies type-extensions as an unnecessary requirement when installing the library into a Python 3.8 environment.
The type-extensions package is referenced in various places as:
importsysfromtypingimportAny, Dict, List, Optional, Sequence, Unionifsys.version_info>= (3, 8): # pragma: no coverfromtypingimportLiteral, TypedDictelse: # pragma: no coverfromtyping_extensionsimportLiteral, TypedDict
Note, sys.version_info >= (3, 8) is always True since playwright only supports versions >=3.8. Consequently, the else block is never executed. Additionally, Literal and TypeDict were introduced into the standard typing module in 3.8 and 3.6, respectively, and a patch should access them from typing.
I am using the latest version. This is more of a code smell than a bug.
Context
The
setup.py
specifiestype-extensions
as an unnecessary requirement when installing the library into a Python 3.8 environment.The
type-extensions
package is referenced in various places as:Note,
sys.version_info >= (3, 8)
is alwaysTrue
since playwright only supports versions >=3.8. Consequently, theelse
block is never executed. Additionally,Literal
andTypeDict
were introduced into the standardtyping
module in 3.8 and 3.6, respectively, and a patch should access them fromtyping
.Environment
The text was updated successfully, but these errors were encountered: