try fixing types

Author: Skn0tt

packages/playwright-core/src/browserServerImpl.ts

@@ -30,6 +30,7 @@ import type { LaunchOptions, LaunchServerOptions, Logger, Env } from './client/t
 import type { ProtocolLogger } from './server/types';
 import type { WebSocketEventEmitter } from './utilsBundle';
 import type { Browser } from './server/browser';
+import type { Browser as ClientBrowser } from './client/browser';
 
 export class BrowserServerLauncherImpl implements BrowserServerLauncher {
   private _browserName: 'chromium' | 'firefox' | 'webkit' | '_bidiFirefox' | '_bidiChromium';
@@ -78,10 +79,17 @@ export class BrowserServerLauncherImpl implements BrowserServerLauncher {
       throw e;
     }
 
-    return this.launchServerOnExistingBrowser(browser, options);
+    return this._launchServerOnExistingBrowser(browser, options);
   }
 
-  async launchServerOnExistingBrowser(browser: Browser, options: LaunchServerOptions): Promise<BrowserServer> {
+  async launchServerOnExistingBrowser(browser: ClientBrowser, options: LaunchServerOptions): Promise<BrowserServer> {
+    const browserImpl = browser._connection.toImpl?.(browser);
+    if (!browserImpl)
+      throw new Error('Launch server is not supported');
+    return this._launchServerOnExistingBrowser(browserImpl, options);
+  }
+
+  private async _launchServerOnExistingBrowser(browser: Browser, options: LaunchServerOptions): Promise<BrowserServer> {
     const path = options.wsPath ? (options.wsPath.startsWith('/') ? options.wsPath : `/${options.wsPath}`) : `/${createGuid()}`;
 
     // 2. Start the server

packages/playwright-core/src/client/browser.ts

@@ -22,7 +22,6 @@ import { isTargetClosedError } from './errors';
 import { Events } from './events';
 import { mkdirIfNeeded } from './fileUtils';
 
-import type { Browser as BrowserImpl } from '../server/browser';
 import type { BrowserType } from './browserType';
 import type { Page } from './page';
 import type { BrowserContextOptions, LaunchOptions, LaunchServerOptions, Logger } from './types';
@@ -148,11 +147,9 @@ export class Browser extends ChannelOwner<channels.BrowserChannel> implements ap
   }
 
   async _launchServer(options: LaunchServerOptions = {}) {
-    const serverLauncher = this._browserType._serverLauncher;
-    const browser: BrowserImpl = this._connection.toImpl?.(this);
-    if (!serverLauncher || !browser)
+    if (!this._browserType._serverLauncher)
       throw new Error('Launching server is not supported');
-    return await serverLauncher.launchServerOnExistingBrowser(browser, {
+    return await this._browserType._serverLauncher.launchServerOnExistingBrowser(this, {
       _sharedBrowser: true,
       ...options,
     });

packages/playwright-core/src/client/browserType.ts

@@ -26,7 +26,6 @@ import { raceAgainstDeadline } from '../utils/isomorphic/timeoutRunner';
 import { connectOverWebSocket } from './webSocket';
 import { TimeoutSettings } from './timeoutSettings';
 
-import type { Browser as BrowserImpl } from '../server/browser';
 import type { Playwright } from './playwright';
 import type { ConnectOptions, LaunchOptions, LaunchPersistentContextOptions, LaunchServerOptions } from './types';
 import type * as api from '../../types/types';
@@ -35,7 +34,7 @@ import type { ChildProcess } from 'child_process';
 
 export interface BrowserServerLauncher {
   launchServer(options?: LaunchOptions & LaunchServerOptions): Promise<api.BrowserServer>;
-  launchServerOnExistingBrowser(browser: BrowserImpl, options?: LaunchServerOptions): Promise<api.BrowserServer>;
+  launchServerOnExistingBrowser(browser: Browser, options?: LaunchServerOptions): Promise<api.BrowserServer>;
 }
 
 // This is here just for api generation and checking.