Skip to content

Commit c41d1be

Browse files
authored
test: tree gardening (#36985)
1 parent 662efa9 commit c41d1be

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

tests/library/browsercontext-events.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ test('console event should work @smoke', async ({ page }) => {
2929

3030
test('console event should work with element handles', async ({ page }) => {
3131
await page.setContent('<body>hello</body>');
32-
const [, message] = await Promise.all([
33-
page.evaluate(() => console.log(document.body)),
32+
const [message] = await Promise.all([
3433
page.context().waitForEvent('console'),
34+
page.evaluate(() => console.log(document.body)),
3535
]);
3636
const body = message.args()[0];
3737
expect(await body.evaluate(x => x.nodeName)).toBe('BODY');

tests/page/jshandle-to-string.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ it('should work with different subtypes @smoke', async ({ page, browserName }) =
6767
expect((await page.evaluateHandle('new Set()')).toString()).toContain('Set');
6868
expect((await page.evaluateHandle('[]')).toString()).toContain('Array');
6969
expect((await page.evaluateHandle('null')).toString()).toBe('null');
70-
expect((await page.evaluateHandle('document.body')).toString()).toBe('JSHandle@node');
70+
const bodyHandle = await page.evaluateHandle('document.body');
71+
await expect.poll(() => bodyHandle.toString()).toBe('JSHandle@<body></body>');
7172
expect((await page.evaluateHandle('new WeakMap()')).toString()).toBe('WeakMap');
7273
expect((await page.evaluateHandle('new WeakSet()')).toString()).toBe('WeakSet');
7374
expect((await page.evaluateHandle('new Error()')).toString()).toContain('Error');

0 commit comments

Comments
 (0)