chore: use screen for output in reporters (#37039)

Author: pavelfeldman

eslint.config.mjs

@@ -339,6 +339,8 @@ export default [
           message:
             "Please use gracefullyProcessExitDoNotHang function to exit the process.",
         },
+        { object: "process", property: "stdout" },
+        { object: "process", property: "stderr" },
       ],
     },
   },
@@ -354,13 +356,6 @@ export default [
       ...noFloatingPromisesRules,
     },
   },
-  {
-    files: ["packages/playwright/src/reporters/**/*.ts"],
-    languageOptions: languageOptionsWithTsConfig,
-    rules: {
-      "no-console": "off",
-    },
-  },
   {
     files: [
       "packages/playwright-core/src/utils/**/*.ts",

packages/playwright-core/src/cli/driver.ts

@@ -38,6 +38,7 @@ export function runDriver() {
     const playwright = createPlaywright({ sdkLanguage });
     return new PlaywrightDispatcher(rootScope, playwright);
   });
+  // eslint-disable-next-line no-restricted-properties
   const transport = new PipeTransport(process.stdout, process.stdin);
   transport.onmessage = (message: string) => dispatcherConnection.dispatch(JSON.parse(message));
   // Certain Language Binding JSON parsers (e.g. .NET) do not like strings with lone surrogates.

packages/playwright-core/src/cli/program.ts

@@ -643,11 +643,13 @@ async function maybeSetupTestHooks(browser: Browser, closeBrowser: () => Promise
   require('playwright-core/lib/utilsBundle').debug.log = (...args: any[]) => {
     const line = require('util').format(...args) + '\n';
     logs.push(line);
+    // eslint-disable-next-line no-restricted-properties
     process.stderr.write(line);
   };
   browser.on('disconnected', () => {
     const hasCrashLine = logs.some(line => line.includes('process did exit:') && !line.includes('process did exit: exitCode=0, signal=null'));
     if (hasCrashLine) {
+      // eslint-disable-next-line no-restricted-properties
       process.stderr.write('Detected browser crash.\n');
       gracefullyProcessExitDoNotHang(1);
     }

packages/playwright-core/src/outofprocess.ts

@@ -47,6 +47,7 @@ class PlaywrightClient {
       },
     });
     this._driverProcess.unref();
+    // eslint-disable-next-line no-restricted-properties
     this._driverProcess.stderr!.on('data', data => process.stderr.write(data));
 
     const connection = new Connection(nodePlatform);

packages/playwright-core/src/server/electron/electron.ts

@@ -292,6 +292,7 @@ export class Electron extends SdkObject {
 
 async function waitForLine(progress: Progress, process: childProcess.ChildProcess, regex: RegExp) {
   const promise = new ManualPromise<RegExpMatchArray>();
+  // eslint-disable-next-line no-restricted-properties
   const rl = readline.createInterface({ input: process.stderr! });
   const failError = new Error('Process failed to launch!');
   const listeners = [

packages/playwright-core/src/server/registry/browserFetcher.ts

@@ -126,6 +126,7 @@ export function logPolitely(toBeLogged: string) {
 type OnProgressCallback = (downloadedBytes: number, totalBytes: number) => void;
 
 function getDownloadProgress(): OnProgressCallback {
+  // eslint-disable-next-line no-restricted-properties
   if (process.stdout.isTTY)
     return getAnimatedDownloadProgress();
   return getBasicDownloadProgress();

packages/playwright-core/src/server/registry/index.ts

@@ -1068,6 +1068,7 @@ export class Registry {
         const { embedderName } = getEmbedderName();
         if (!getAsBooleanFromENV('CI') && !executable._isHermeticInstallation && !forceReinstall && executable.executablePath(embedderName)) {
           const command = buildPlaywrightCLICommand(embedderName, 'install --force ' + executable.name);
+          // eslint-disable-next-line no-restricted-properties
           process.stderr.write('\n' + wrapInASCIIBox([
             `ATTENTION: "${executable.name}" is already installed on the system!`,
             ``,
@@ -1132,6 +1133,7 @@ export class Registry {
 
   async validateHostRequirementsForExecutablesIfNeeded(executables: Executable[], sdkLanguage: string) {
     if (getAsBooleanFromENV('PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS')) {
+      // eslint-disable-next-line no-restricted-properties
       process.stderr.write('Skipping host requirements validation logic because `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS` env variable is set.\n');
       return;
     }

packages/playwright-core/src/server/trace/viewer/traceViewer.ts

@@ -182,8 +182,10 @@ export async function openTraceViewerApp(url: string, browserName: string, optio
   await controller.run(async progress => {
     await context._browser._defaultContext!._loadDefaultContextAsIs(progress);
 
-    if (process.env.PWTEST_PRINT_WS_ENDPOINT)
+    if (process.env.PWTEST_PRINT_WS_ENDPOINT) {
+      // eslint-disable-next-line no-restricted-properties
       process.stderr.write('DevTools listening on: ' + context._browser.options.wsEndpoint + '\n');
+    }
 
     if (!isUnderTest())
       await syncLocalStorageWithSettings(page, 'traceviewer');

packages/playwright-core/src/server/utils/spawnAsync.ts

@@ -24,10 +24,12 @@ export function spawnAsync(cmd: string, args: string[], options: SpawnOptions =
   return new Promise(resolve => {
     let stdout = '';
     let stderr = '';
+    /* eslint-disable no-restricted-properties */
     if (process.stdout)
       process.stdout.on('data', data => stdout += data.toString());
     if (process.stderr)
       process.stderr.on('data', data => stderr += data.toString());
+    /* eslint-enable no-restricted-properties */
     process.on('close', code => resolve({ stdout, stderr, code }));
     process.on('error', error => resolve({ stdout, stderr, code: 0, error }));
   });

packages/playwright/src/program.ts

@@ -234,7 +234,9 @@ async function runTestServer(opts: { [key: string]: any }) {
 
 export async function withRunnerAndMutedWrite(configFile: string | undefined, callback: (runner: Runner) => Promise<any>) {
   // Redefine process.stdout.write in case config decides to pollute stdio.
+  // eslint-disable-next-line no-restricted-properties
   const stdoutWrite = process.stdout.write.bind(process.stdout);
+  // eslint-disable-next-line no-restricted-properties
   process.stdout.write = ((a: any, b: any, c: any) => process.stderr.write(a, b, c)) as any;
   try {
     const config = await loadConfigFromFile(configFile);