Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Docker image for Node 22 or change Node from 20 to 22 #32177

Closed
lukaselmer opened this issue Aug 15, 2024 · 6 comments · Fixed by #33348
Closed

[Feature]: Docker image for Node 22 or change Node from 20 to 22 #32177

lukaselmer opened this issue Aug 15, 2024 · 6 comments · Fixed by #33348
Assignees
Labels

Comments

@lukaselmer
Copy link

🚀 Feature Request

Release a Docker image built with Node 22 and describe it's usage here: https://playwright.dev/docs/docker

Example

E.g. docker pull mcr.microsoft.com/playwright:v1.46.0-jammy-22, or change the default from 20 to 22.

Motivation

The current docker images https://github.com/microsoft/playwright/tree/main/utils/docker are based on Node 20. With Node 22 LTS around the corner, and with issues / workaround which work only on Node 22 like #23662 (comment), it would be helpful to have a Docker image built with Node 22.

@pavelfeldman
Copy link
Member

Our docker images are aligned with Node LTS. Marking for 1.47 to track in case Node 22 makes it to LTS.

@mxschmitt mxschmitt self-assigned this Aug 15, 2024
@mxschmitt
Copy link
Member

Note: Node.js 22 will enter long-term support (LTS) in October - until then we'll move this issue forward to the next release.

@mxschmitt mxschmitt added v1.48 and removed v1.47 labels Aug 19, 2024
@dimkin-eu
Copy link

i found this a great idea - postfix node version ( at least for 1 release )
I.e. having

  • mcr.microsoft.com/playwright:v1.48.0-jammy ( with node 20 )
  • mcr.microsoft.com/playwright:v1.48.0-jammy-22 ( with node 22 )

moving to mcr.microsoft.com/playwright:v1.49.0-jammy with 22 only

@mxschmitt mxschmitt added v1.49 and removed v1.48 labels Sep 10, 2024
@grafjo
Copy link

grafjo commented Oct 29, 2024

today node 22 was announced to be the current lts version, so it would be awesome to bump the docker images to node 22

@Baloche
Copy link

Baloche commented Nov 8, 2024

Now that this is merged, when will the node 22 image be published to the microsoft artifact registry 🙂 ?

@mxschmitt
Copy link
Member

Now that this is merged, when will the node 22 image be published to the microsoft artifact registry 🙂 ?

As part of the next Playwright release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants