-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] [Docker] Husky fail to install on docker image #7136
Labels
upstream
This is a bug in something playwright depends on, like a browser.
Comments
Would it be possible that you could create a minimum reproducible in form of a GitHub repository for us? |
@mxschmitt I'll give it a try |
I was able to track it a little bit down. When using Node.js 14/15 inside the Docker container, it works correctly. You can install Node.js 14 there with the following commands: apt-get remove nodejs
curl -fsSL https://deb.nodesource.com/setup_14.x | bash -
apt-get install -y nodejs Related links: |
mxschmitt
added
upstream
This is a bug in something playwright depends on, like a browser.
and removed
triaging
labels
Jun 15, 2021
mxschmitt
changed the title
[BUG] Husky fail to install on docker image
[BUG] [Docker] Husky fail to install on docker image
Jun 15, 2021
I used
Works too 😀 |
Closed since we switched to Node.js 14 in #7212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Husky from @typicode is added as devDependency with a prepare script to install the hooks according to documentation.
The prepare step fails on the
mcr.microsoft.com/playwright:focal
container due to missing permissions.Github Actions job is configured as follow:
This is the error ouptut from the CI:
The same script runs fine on e.g.
node:lts-buster
containerThe text was updated successfully, but these errors were encountered: