Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Please provide arm64 docker images as well #853

Open
nathanhruby opened this issue Apr 20, 2022 · 3 comments
Open

Feature: Please provide arm64 docker images as well #853

nathanhruby opened this issue Apr 20, 2022 · 3 comments
Labels
docker enhancement New feature or request good first issue Good for newcomers

Comments

@nathanhruby
Copy link

Describe the bug
Would you also build containers for arm64/v8 to support Apple M1? Thanks!

To Reproduce
Steps to reproduce the behavior:

  1. Get a M1 or ARM64 machine
  2. docker pull mcr.microsoft.com/presidio-analyzer:latest
  3. docker run mcr.microsoft.com/presidio-analyzer

Expected behavior
Runs super fast without warning

Additional context

 ~  uname -a
Darwin box.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:47:26 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T8101 arm64
 ~  date ; docker run --rm -it mcr.microsoft.com/presidio-analyzer
Wed Apr 20 09:39:31 MST 2022
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
2022-04-20 16:39:40,797 - presidio-analyzer - INFO - Starting analyzer engine
2022-04-20 16:39:40,799 - presidio-analyzer - INFO - nlp_engine not provided, creating default.
2022-04-20 16:40:00,274 - presidio-analyzer - INFO - Created NLP engine: spacy. Loaded models: ['en']
2022-04-20 16:40:00,277 - presidio-analyzer - INFO - registry not provided, creating default.
2022-04-20 16:40:00,280 - presidio-analyzer - INFO - Loaded recognizer: UsBankRecognizer
2022-04-20 16:40:00,283 - presidio-analyzer - INFO - Loaded recognizer: UsLicenseRecognizer
2022-04-20 16:40:00,284 - presidio-analyzer - INFO - Loaded recognizer: UsItinRecognizer
2022-04-20 16:40:00,284 - presidio-analyzer - INFO - Loaded recognizer: UsPassportRecognizer
2022-04-20 16:40:00,284 - presidio-analyzer - INFO - Loaded recognizer: UsSsnRecognizer
2022-04-20 16:40:00,285 - presidio-analyzer - INFO - Loaded recognizer: NhsRecognizer
2022-04-20 16:40:00,286 - presidio-analyzer - INFO - Loaded recognizer: SgFinRecognizer
2022-04-20 16:40:00,286 - presidio-analyzer - INFO - Loaded recognizer: AuAbnRecognizer
2022-04-20 16:40:00,287 - presidio-analyzer - INFO - Loaded recognizer: AuAcnRecognizer
2022-04-20 16:40:00,287 - presidio-analyzer - INFO - Loaded recognizer: AuTfnRecognizer
2022-04-20 16:40:00,288 - presidio-analyzer - INFO - Loaded recognizer: AuMedicareRecognizer
2022-04-20 16:40:00,289 - presidio-analyzer - INFO - Loaded recognizer: CreditCardRecognizer
2022-04-20 16:40:00,289 - presidio-analyzer - INFO - Loaded recognizer: CryptoRecognizer
2022-04-20 16:40:00,290 - presidio-analyzer - INFO - Loaded recognizer: DateRecognizer
2022-04-20 16:40:00,291 - presidio-analyzer - INFO - Loaded recognizer: EmailRecognizer
2022-04-20 16:40:00,291 - presidio-analyzer - INFO - Loaded recognizer: IbanRecognizer
2022-04-20 16:40:00,291 - presidio-analyzer - INFO - Loaded recognizer: IpRecognizer
2022-04-20 16:40:00,292 - presidio-analyzer - INFO - Loaded recognizer: MedicalLicenseRecognizer
2022-04-20 16:40:00,292 - presidio-analyzer - INFO - Loaded recognizer: SpacyRecognizer
2022-04-20 16:40:00,293 - presidio-analyzer - INFO - Loaded recognizer: PhoneRecognizer
2022-04-20 16:40:00,293 - presidio-analyzer - INFO - Loaded recognizer: UrlRecognizer
2022-04-20 16:40:00,293 - presidio-analyzer - INFO -
 _______  _______  _______  _______ _________ ______  _________ _______
(  ____ )(  ____ )(  ____ \(  ____ \\__   __/(  __  \ \__   __/(  ___  )
| (    )|| (    )|| (    \/| (    \/   ) (   | (  \  )   ) (   | (   ) |
| (____)|| (____)|| (__    | (_____    | |   | |   ) |   | |   | |   | |
|  _____)|     __)|  __)   (_____  )   | |   | |   | |   | |   | |   | |
| (      | (\ (   | (            ) |   | |   | |   ) |   | |   | |   | |
| )      | ) \ \__| (____/\/\____) |___) (___| (__/  )___) (___| (___) |
|/       |/   \__/(_______/\_______)\_______/(______/ \_______/(_______)

 * Serving Flask app 'app' (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
2022-04-20 16:40:00,349 - werkzeug - WARNING -  * Running on all addresses.
   WARNING: This is a development server. Do not use it in a production deployment.
2022-04-20 16:40:00,351 - werkzeug - INFO -  * Running on http://172.17.0.3:3000/ (Press CTRL+C to quit)
@omri374
Copy link
Contributor

omri374 commented Apr 22, 2022

Hi @nathanhruby,

This is a great suggestion and we will look into this. If you or anyone else is interested in creating a PR, please do so and we would be happy to review.

@omri374 omri374 added enhancement New feature or request good first issue Good for newcomers docker labels Apr 22, 2022
@nathanhruby
Copy link
Author

Hi! I looked at making a quick PR, but the build system currently doesn't seem to use new docker buildkit features that make multiplatform builds easier and I'm not really sure how to get Azure Devops to target arm/v8.

@jaxony
Copy link

jaxony commented Nov 20, 2024

This would be nice to have. More and more people are developing with M1/M2 chips 2 years later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants