Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable WebUSB by board variant instead of compile service #250

Closed
Amerlander opened this issue Nov 8, 2023 · 4 comments · Fixed by #261
Closed

Enable/Disable WebUSB by board variant instead of compile service #250

Amerlander opened this issue Nov 8, 2023 · 4 comments · Fixed by #261

Comments

@Amerlander
Copy link
Collaborator

Currently the availablility of webUSB is defined in pxtarget.json.compile and could be overwritten by defining different compile variants.

We have three baord definitions, two of them are sharing one compile variant. Since one board do not allow webUSB yet it has to be disabled for both. Is there a way to enable/disable webUSB in pxt.json of the board core library instead of the compile service?

Current webUSB flag:

"webUSB": false

mini 1 core package (should support webUSB)
https://github.com/microsoft/pxt-calliope/blob/master/libs/v1/pxt.json

mini 2 core package (should not yet support webUSB)
https://github.com/microsoft/pxt-calliope/blob/master/libs/v2/pxt.json

@jwunderl can you tell if this is possible somehow? If #248 is solved we would not require to disable webUSB for a specific device, but in the meanwhile it would be good to be able to enable web usb for the Calliope mini 1 devices.

@Amerlander Amerlander changed the title Enable/Disable WebUSB by board instead of compile service Enable/Disable WebUSB by board variant instead of compile service Nov 17, 2023
@Amerlander
Copy link
Collaborator Author

@abchatra can we get help on this?

@abchatra
Copy link
Contributor

@riknoll any workarounds here?

@riknoll
Copy link
Member

riknoll commented Nov 21, 2023

this is not supported today AFAIK and would not be trivial to add... @Amerlander couldn't you just duplicate the compile variant and change that one setting? I'm not sure I understand why they have to share it.

@Amerlander
Copy link
Collaborator Author

Thank you for that feedback. Dublicating the compile variant is an option, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants