Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The radio part does not take effect on hardware #2823

Closed
Sheila111 opened this issue Apr 16, 2020 · 9 comments · Fixed by microsoft/pxt#6891
Closed

The radio part does not take effect on hardware #2823

Sheila111 opened this issue Apr 16, 2020 · 9 comments · Fixed by microsoft/pxt#6891
Assignees
Labels
bug device For bugs that repro on the device next-release P2

Comments

@Sheila111
Copy link

Sheila111 commented Apr 16, 2020

Describe the bug
The radio part does not take effect on hardware

Steps to reproduce the behavior
1.Navigate to https://makecode.microbit.org/beta#
2.Radio Games---->Mood Radio
3.Show Instructions
4.Click "Download"
5.Run it on the hardware

Expect behavior
This project uses the radio to share your mood with other micro:bits. When you press A, other microbit will see a smiley face too. When you press B, other microbit will also see a frowny face.
1

Actual behavior
It just shows happy image when pressing button A. Another microbit shows nothing.
It seems that the radio part does not take effect on hardware

Additional context
1.OS: Windows(rs6)
2.makecode.microbit.org version: 2.3.15
3.Microsoft MakeCode version: 5.37.25
4.The live version runs normally on hardware

@abchatra
Copy link
Collaborator

@Sheila111 What is the behavior in live? (Is this a regression)?
Also try Radio -> "Set Group" in On Start and see if the issue goes away

@Sheila111
Copy link
Author

Sheila111 commented Apr 16, 2020

@abchatra The live version runs normally on hardware even if I don't add "Set Group" in On Start.
And I tried Radio -> "Set Group" in On Start and the issue doesn't go away.

@abchatra abchatra added device For bugs that repro on the device bug P2 next-release and removed needs additional information labels Apr 16, 2020
@mmoskal
Copy link
Member

mmoskal commented Apr 16, 2020

works for me on master

@pelikhan
Copy link
Member

I can repro on /beta.

@pelikhan
Copy link
Member

It works on /beta after setting the group in onstart.

@abchatra
Copy link
Collaborator

@finneyj @jamesadevine

@pelikhan
Copy link
Member

We need to verify that we generate the same program hash on every compile. This works by setting group so it might be that our program hash is not stable anymore.

@pelikhan
Copy link
Member

@mmoskal did we introduce a random seed in the generated code?

@mmoskal
Copy link
Member

mmoskal commented Apr 22, 2020

it's the incremental compilation I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug device For bugs that repro on the device next-release P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants