Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment creation fails in Safari <17.4: Missing checkVisibility function #10264

Open
Amerlander opened this issue Nov 13, 2024 · 0 comments
Open

Comments

@Amerlander
Copy link
Contributor

Bug Report

Summary

In Safari versions below 17.4, creating a comment in blank space (not linked to a block) does not work. This issue is likely caused by the checkVisibility function, which is unavailable in earlier Safari versions (pre-17.4), released before March 5, 2024. Reference: CanIUse.

Steps to Reproduce

  1. Open Safari (version below 17.4)
  2. Visit MakeCode Microbit Editor
  3. Attempt to add a comment on blank space (not attached to a block)
  4. Observe that only a trash icon appears instead of a comment field

Screenshot:
Error Screenshot

Expected Behavior

A complete comment field should appear instead of just the trash icon.

Expected Screenshot:
Expected Comment Field

Environment

  • OS: macOS
  • Browser: Safari
  • Version: 16.6 (18615.3.12.11.2)

Additional Information

Console Error:

[Error] TypeError: this.foldoutIcon.checkVisibility is not a function. (In 'this.foldoutIcon.checkVisibility()', 'this.foldoutIcon.checkVisibility' is undefined)
    calcMinSize (main.js:7:178205)
    setSize (main.js:7:177588)
    yc (main.js:7:175954)
    Ku (main.js:7:211726)
    callback (main.js:7:124434)
    (anonymous function) (main.js:7:77740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant