Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many repeated parameters are recommended after I update pylance! #215

Closed
CatNofishing opened this issue Aug 8, 2020 · 5 comments
Closed
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@CatNofishing
Copy link

Environment data

version: 1.47.3 (user setup)
commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
date: 2020-07-23T13:12:49.994Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Pylance: 2020.8.0
To find your version, you can either:

Incredibly repeated parameters

image

This issue is similiar to #12503,now pylance has the similiar problem.

@github-actions github-actions bot added the triage label Aug 8, 2020
@erictraut
Copy link
Contributor

Thanks for the bug report. I've introduced a fix, and it will be in the next release of Pylance.

In case you're curious of the cause of the bug, Pylance was adding symbols from the current scope and all outer scopes (which is correct), but it wasn't properly detecting and dedup'ing symbol names that appeared in outer scopes.

@erictraut erictraut added bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version labels Aug 8, 2020
@CatNofishing
Copy link
Author

Thanks for your reply.😁

@jakebailey
Copy link
Member

This issue has been fixed in version 2020.8.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202081-13-august-2020

@CatNofishing
Copy link
Author

image
This issue appears in pylance v2020.11.3-pre.1

@jakebailey
Copy link
Member

@CatNofishing That's a different issue, actually; we probably don't want to be offering autoimports for things that are already named parameters, or at least ranking them differently. Would you mind opening a new issue with that screenshot so we can track it? This is a closed issue that was fixed a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants