Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go to implementation should find implementation of all sub types transitively. #6775

Open
heejaechang opened this issue Dec 16, 2024 · 2 comments
Assignees

Comments

@heejaechang
Copy link
Contributor

heejaechang commented Dec 16, 2024

class A:
     def method(self): pass

class B(A):
     def method(self): pass

class C(B):
     def method(self): pass

go to impl or find all impl on A.method should show C.method as well.

also, it should include A.method as well since A.method can have implementation as well unless it is hard as abstract

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Dec 16, 2024
@heejaechang heejaechang assigned StellaHuang95 and unassigned debonte Dec 16, 2024
@rchiodo
Copy link
Contributor

rchiodo commented Dec 16, 2024

class A:
     def method(self): pass

class B(A):
     def method(self): pass

class C(B):
     def method(self): pass

x = B()
x.method()

Goto impl on x.method should also jump to B.method

@StellaHuang95
Copy link
Contributor

StellaHuang95 commented Dec 16, 2024

class A:
def method(self): pass

class B(A):
def method(self): pass

class C(B):
def method(self): pass

x = B()
x.method()
Goto impl on x.method should also jump to B.method

Right now for a hierarchy like A->B->C, go to implementation only goes to B and C, I will make the behavior to be it goes to A, B, and C if A is not abstract, and B, C if A is abstract. That should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants