Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pandas stubs to the ones maintained by pandas team #191

Closed
gramster opened this issue Apr 27, 2022 · 6 comments
Closed

Switch pandas stubs to the ones maintained by pandas team #191

gramster opened this issue Apr 27, 2022 · 6 comments

Comments

@gramster
Copy link
Member

This is not something we can do yet (as I write this), but the pandas team are going to take over stub maintenance at some point and move them to a package on PyPI.

Meanwhile, we need to decide what to do about open issues we have for our stubs. @Dr-Irv, do you have an insight into the timeline and should we still fix issues here?

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Apr 27, 2022

I've started the process of creating a repo in the pandas project, and have to do a bit more work before we can decide to publicize it. It's somewhat dependent on my time to do this work. I would hope that by the end of June we have a public repo.

I think we should continue to fix issues here so that people using the MS shipped stubs get fixes as they identify the need, since you're doing new releases in VS Code on a weekly basis.

As changes happen here for the pandas stubs, I'll copy them over to the repo I've created over in the pandas project (which is currently private - visible to the pandas core team)

@Dr-Irv
Copy link
Contributor

Dr-Irv commented May 24, 2022

The repo is now public: https://github.com/pandas-dev/pandas-stubs

@alkatar21
Copy link

Since #208 has been merged. Is there already a date when the first pylane release with the new pandas stubs will be published?

@alkatar21
Copy link

@Dr-Irv @gramster According to python-in-visual-studio-code-june-2022-release, the stubs from https://github.com/pandas-dev/pandas-stubs are now used, but in pylance v2022.6.10 at least pandas-dev/pandas-stubs#15 (#199) seems to be missing and I can't find it in https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md either.
Are there any further information, or should I create an issue in the pylance repo?

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jun 10, 2022

@alkatar1 I have nothing to do with the pylance releases, so hopefully @gramster can answer. Or @luabud who wrote that blog.

@gramster
Copy link
Member Author

gramster commented Jun 15, 2022

Will be fixed in next release (likely today); the blog post jumped the gun a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants