Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane Renderer does not cover entire screen for translucent or hidden Status Bar #131

Open
Vedantthakkar opened this issue Mar 31, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Vedantthakkar
Copy link

Vedantthakkar commented Mar 31, 2022

Hi

One of the components in my app requires the status bar to be translucent and I am making it happen using the following code:

Screenshot (20)

Although the app covers the area of the status bar, there appears a white line at the bottom of the app. The page looks something like this:
Screenshot (19)

The white line also appears for the "hidden" state of status bar. I suspect that pane renderer does not take into account the state of the status bar. It considers the dimension of the area except the status bar and renders using the height of that dimension. I tried changing the paneRects manually and it did cover the entire screen but could not come up with something that can adjust the paneRects based on the state of the status bar("hidden" or "translucent" ). Is there any solution to this situation ?

@ghost ghost added the Needs: triage 🔍 label Mar 31, 2022
@chrisglein
Copy link
Member

Layout will not be adjusted for items that are translucent generally. To get layout to update items generally would need to be hidden (or remove from React tree). Why are you setting it to translucent instead of hiding it? What's the scenario?

@Vedantthakkar
Copy link
Author

The idea is to give a full screen experience for a particular feature while the status bar is also somewhat visible. Although hiding the status bar is also an option I started with translucent. But neither of the two options (translucent or hidden) seems to work as for both of them there is a white line at the bottom. As react-native-twopane-navigation is the container library for the screens, is this case being handled at the container (paneRender) level? If not is there any specific recommendation to handle such cases (It will be great if you could give some code examples)?

@chrisglein chrisglein added bug Something isn't working and removed Needs: attention 👋 labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants