Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix loading of core modules on 0.75 + New Arch #2126

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 16, 2024

Description

Fix loading of core modules on 0.75 + New Arch: facebook/react-native@7facb32

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

@tido64 tido64 requested a review from JasonVMo as a code owner July 16, 2024 08:45
@github-actions github-actions bot added the platform: Android This affects Android label Jul 16, 2024
@tido64 tido64 mentioned this pull request Jul 16, 2024
30 tasks
Copy link

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you gone through and tested the code on downlevel versions as well? The main concern is that we end up referencing modules that don't exist in older versions with the new references (though it looks protected by the right ifdefs)

@tido64
Copy link
Member Author

tido64 commented Jul 16, 2024

Have you gone through and tested the code on downlevel versions as well? The main concern is that we end up referencing modules that don't exist in older versions with the new references (though it looks protected by the right ifdefs)

I have and it works. The #ifdef is working.

@tido64 tido64 merged commit 6c8451f into trunk Jul 17, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/fix-bridgeless-core-modules branch July 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants