Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create guide for adding macOS support to an existing community module #159

Open
chrisglein opened this issue Jul 6, 2020 · 3 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request Extensions Platform: macOS
Milestone

Comments

@chrisglein
Copy link
Member

Typically the engineering here is lower than say a Windows module because the iOS code can be leveraged. The higher cost is knowing what to do, and going through the PR process. We should document that to help external contributors to help out here.

Of note we need this for Windows too... I know there was some discussion/issue on that, but I couldn't find it.

@ghost ghost added the Needs: Triage 🔍 label Jul 6, 2020
@chrisglein chrisglein added the documentation Improvements or additions to documentation label Jul 6, 2020
@chrisglein
Copy link
Member Author

@tom-un You've mentioned that you've done a few of these and have pointed people to PRs for those as reference. Can you link the PRs or whatever you've linked before here as a starter? Any additional amount you can seed some documentation would help, then hopefully we can share some of the effort to build out docs for this for Windows and macOS.

Speaking of the Windows side, @stmoy I'm thinking of this:
https://microsoft.github.io/react-native-windows/docs/native-modules-setup#Adding-Windows-support-to-an-existing-library
I'm not sure that's discoverable enough - took me some clicking and scrolling to find it. What do you think?

@tom-un
Copy link
Contributor

tom-un commented Jul 10, 2020

@chrisglein Here are the PR's I've done to contribute macOS implementations to existing react-native-community repos:
react-native-webview: react-native-webview/react-native-webview#1164
async-storage: react-native-async-storage/async-storage#296
react-native-netinfo: react-native-netinfo/react-native-netinfo#312

@chrisglein
Copy link
Member Author

FYI @amgleitman we have the issue tracking need for an article on adding macOS support to existing native modules here (on the samples repo where the website is built from, not the macOS repo). If you can put together some content we can help you walk through the website parts. Some documentation here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Extensions Platform: macOS
Projects
None yet
Development

No branches or pull requests

4 participants