Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Microsoft.ReactNative.Win32.CppApp.props #11416

Open
chiaramooney opened this issue Mar 23, 2023 · 3 comments
Open

Create Microsoft.ReactNative.Win32.CppApp.props #11416

chiaramooney opened this issue Mar 23, 2023 · 3 comments
Labels
Area: App Template Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: ES Compliance SFI Provide regular ES infrastructure and ensur RNW meets internal security and compliance requirements.
Milestone
Backlog

Comments

@chiaramooney
Copy link
Contributor

Proposal from #11407.

We should consider making a Microsoft.ReactNative.Win32.CppApp.props (or something else instead of Win32) so we can start to diverge from the UWP requirements without overcomplicating the existing file.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 23, 2023
@chiaramooney chiaramooney mentioned this issue Mar 23, 2023
Merged
@chrisglein chrisglein added enhancement Area: Fabric Support Facebook Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 23, 2023
@chrisglein chrisglein added this to the 0.73 milestone Mar 23, 2023
@chiaramooney chiaramooney added the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Mar 28, 2023
@chiaramooney
Copy link
Contributor Author

Agree that this should be work for 0.73 milestone instead of v0.72. Not immediately pressing work. Functionality works fine for now, but will be good to do this work in future. Tagging with needs attention so it can be assigned to the right dev.

@chrisglein chrisglein removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Mar 30, 2023
@TatianaKapos
Copy link
Contributor

This didn't get done is v73, is this work required for v74 or should it be moved to backlog?

@TatianaKapos TatianaKapos added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 9, 2023
@TatianaKapos TatianaKapos modified the milestones: 0.73, 0.74 Dec 9, 2023
@TatianaKapos TatianaKapos added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 9, 2023
@chrisglein
Copy link
Member

@jonthysell how does this align with your app template work? Part of #11920 or no?

@chrisglein chrisglein modified the milestones: 0.74, Backlog Dec 14, 2023
@chrisglein chrisglein added Area: App Template and removed Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) labels Dec 14, 2023
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@chiaramooney chiaramooney added the Workstream: ES Compliance SFI Provide regular ES infrastructure and ensur RNW meets internal security and compliance requirements. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: App Template Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: ES Compliance SFI Provide regular ES infrastructure and ensur RNW meets internal security and compliance requirements.
Projects
RNW New Architecture
Status: No status
Milestone
Backlog
Development

No branches or pull requests
5 participants
@jonthysell @chrisglein @YajurG @chiaramooney @TatianaKapos