Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TextInput.onChangeText for Fabric #11462

Closed
Tracked by #119
, #11145
...
chrisglein opened this issue Apr 7, 2023 · 3 comments
Closed
Tracked by #119
, #11145
...

Implement TextInput.onChangeText for Fabric #11462

chrisglein opened this issue Apr 7, 2023 · 3 comments
Assignees
@TatianaKapos
Labels
Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
0.73

Comments

@chrisglein
Copy link
Member

chrisglein commented Apr 7, 2023 •
edited
Loading

Part of #11145

This one is particularly egregious because without this working you can't actually get the text out of a TextInput.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 7, 2023
@chrisglein chrisglein changed the title onChangeText Implement TextInput.onChangeText for Fabric Apr 7, 2023
This was referenced Apr 7, 2023
Closed
Open
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 10, 2023
@chrisglein chrisglein added this to the 0.73 milestone Apr 10, 2023
@chrisglein
Copy link
Member Author

Seems to be working fine? Not sure why it's not marked in the table. @jonthysell why was this one unchecked?

 onChangeText TIVM Pri 1 Event is topTextInputChangeText

@chrisglein
Copy link
Member Author

This works as far as I can tell. Not sure why it wasn't set in the table. @jonthysell @TatianaKapos do you know?

@TatianaKapos
Copy link
Contributor

Tested on rntester, this works in fabric today so I'm going to close this issue and update the table :)

@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
0.73
Development

No branches or pull requests
3 participants
@jonthysell @chrisglein @TatianaKapos