Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patches for invalid type errors #12404

Closed
YajurG opened this issue Nov 16, 2023 · 4 comments
Closed

Remove patches for invalid type errors #12404

YajurG opened this issue Nov 16, 2023 · 4 comments

Comments

@YajurG
Copy link
Contributor

YajurG commented Nov 16, 2023

Linked to: #12429

Remove patch in FloatOptional.h (constexpr declaration in lines 32, 39, 43, 47, 50, 54, 57, 61, 65, 69, 73, 77, 81):

Remove patch in Comparison.h:

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 16, 2023
@chrisglein
Copy link
Member

@YajurG can you link this to the general C++20 issue. We'll want to remove these as part of those.

@chrisglein chrisglein added this to the 0.74 milestone Nov 16, 2023
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Nov 16, 2023
@NickGerleman
Copy link
Collaborator

FYI that there are more, and more invasive usages of C++ 20 coming in future changes.

I left some context in #12331, but most of the fixes neded for C++ 20 are already merged. There are just a few left, where std::future needs to get replaced with an alternative like IAsyncOperation.

@chrisglein chrisglein modified the milestones: 0.74, Next Apr 9, 2024
@chrisglein
Copy link
Member

Possible these were deleted. @marlenecota were these removed?

@marlenecota
Copy link
Contributor

Removed by #12679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants