Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate With New 0.62 View Events #4592

Closed
NickGerleman opened this issue Apr 14, 2020 · 7 comments
Closed

Integrate With New 0.62 View Events #4592

NickGerleman opened this issue Apr 14, 2020 · 7 comments
Assignees
Milestone

Comments

@NickGerleman
Copy link
Collaborator

0.62 added:

  • BlurEvent,
  • FocusEvent,
  • MouseEvent,

MouseEvent directly overlaps with our special version. It seems like these might not actually be implemented to do anything in OSS RN right now though? Followup investigation is needed.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 14, 2020
@NickGerleman NickGerleman added this to the 0.62 (M5) milestone Apr 14, 2020
@chrisglein
Copy link
Member

These don't appear to be in the docs: https://reactnative.dev/docs/view
@kikisaints you've been interacting with FB over the Pressable API - why were these ones not added to the docs? Is it on a list that hasn't been updated?
@harinikmsft This seems like something we should raise in the next sync.

@chrisglein chrisglein added Area: Mouse and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 16, 2020
@harinikmsft harinikmsft added enhancement Needs: PM Design New feature or request and removed enhancement labels Apr 21, 2020
@harinikmsft
Copy link
Contributor

@NickGerleman , @kmelmon - would one of you be able to unearth the actual commits that brought these changes in? Per the latest sync, it is not clear whether these events are fully baked and why they were introduced.

Given the ambiguity on this and the fact that they are net new (non-breaking for windows apps), we should be ok to reconcile after 0.62 preview is ready. Moving to next milestone.

@harinikmsft harinikmsft modified the milestones: 0.62 (M5), 0.63 (M6) Apr 23, 2020
@NickGerleman
Copy link
Collaborator Author

@kmelmon
Copy link
Contributor

kmelmon commented Apr 23, 2020

Thanks Nick. The commit was done in October 2019, well before we started reviewing the changelogs, so this explains why we were unaware of the change. @harinikmsft I do think it would be good to circle back with facebook folks, it may require a one-off meeting.

@chrisglein
Copy link
Member

@harinikmsft does this tie in with the keyboard work we're doing? Seems important to partners (can you confirm and tag as appropriate), but also is it necessary for 0.63? May be appropriate to break this into separate issues.

@harinikmsft
Copy link
Contributor

Pinging @TheSavior - can you share some additional context for these events that seem to have been introduced during 0.62?

These did not come up in the review of keyboard/focus API docs. Are these relevant to consider for all platforms?

@harinikmsft
Copy link
Contributor

Confirmed with React Native team that these APIs are not being used anywhere and can be ignored (do not integrate in RNW at this time). The RN team is aligned that these should be revisited as part of the focus/pointer APIs that are getting designed in the RNW repo at this time and reconcile with web APIs as makes sense.

Closing this issue and linking to other relevant feature requests for book keeping: #2099 , #5706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants