-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate With New 0.62 View Events #4592
Comments
These don't appear to be in the docs: https://reactnative.dev/docs/view |
@NickGerleman , @kmelmon - would one of you be able to unearth the actual commits that brought these changes in? Per the latest sync, it is not clear whether these events are fully baked and why they were introduced. Given the ambiguity on this and the fact that they are net new (non-breaking for windows apps), we should be ok to reconcile after 0.62 preview is ready. Moving to next milestone. |
Thanks Nick. The commit was done in October 2019, well before we started reviewing the changelogs, so this explains why we were unaware of the change. @harinikmsft I do think it would be good to circle back with facebook folks, it may require a one-off meeting. |
@harinikmsft does this tie in with the keyboard work we're doing? Seems important to partners (can you confirm and tag as appropriate), but also is it necessary for 0.63? May be appropriate to break this into separate issues. |
Pinging @TheSavior - can you share some additional context for these events that seem to have been introduced during 0.62? These did not come up in the review of keyboard/focus API docs. Are these relevant to consider for all platforms? |
Confirmed with React Native team that these APIs are not being used anywhere and can be ignored (do not integrate in RNW at this time). The RN team is aligned that these should be revisited as part of the focus/pointer APIs that are getting designed in the RNW repo at this time and reconcile with web APIs as makes sense. Closing this issue and linking to other relevant feature requests for book keeping: #2099 , #5706 |
0.62 added:
MouseEvent directly overlaps with our special version. It seems like these might not actually be implemented to do anything in OSS RN right now though? Followup investigation is needed.
The text was updated successfully, but these errors were encountered: