Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM64 on Windows Desktop #5828

Closed
2 of 5 tasks
JunielKatarn opened this issue Aug 25, 2020 · 6 comments · Fixed by #5864
Closed
2 of 5 tasks

Support ARM64 on Windows Desktop #5828

JunielKatarn opened this issue Aug 25, 2020 · 6 comments · Fixed by #5864

Comments

@JunielKatarn
Copy link
Contributor

JunielKatarn commented Aug 25, 2020

Summary

Produce native ARM64 binaries for Windows Desktop (Windows 8.1 and later).

Work will be tracked on this fork branch:
https://github.com/jurocha-ms/react-native-windows/tree/desktop-arm64

Motivation

Partner project (MS Office) now requires ARM64 builds of React Native. This requires porting react-native-win32.dll.

Dependencies

To deliver this new platform build, we need to either port or stub the following external libraries:

@JunielKatarn JunielKatarn self-assigned this Aug 25, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 25, 2020
@Poopooracoocoo
Copy link

Why do you guys use ChakraCore? And do you guys know if Facebook will be using RNW for Instagram? That'd convince a lot of people. And how come Skype moved away from RNW? What does that say to anyone thinking of using RNW?

@asklar
Copy link
Member

asklar commented Aug 27, 2020

@Poopooracoocoo Skype never used RNW, they had a thing called ReactXP: https://microsoft.github.io/reactxp/blog/2017/04/27/building-skype-on-reactxp.html

My personal opinion (not Microsoft-official :-) ) is that the cost of updating and maintaining ReactXP to keep up with react native became too much. At the end of the day they are an app/service team, not an app framework team.

@Poopooracoocoo
Copy link

@asklar thank you for the response. <3 I didn't want a microsoft official response anyway :p
let's hope they switch to RNW and that Facebook notices and uses your project. :)

I thought that Microsoft wasn't using ChakraCore: chakra-core/ChakraCore#6384

@kmelmon kmelmon removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 27, 2020
@kmelmon kmelmon added this to the 0.64 milestone Aug 27, 2020
@NickGerleman NickGerleman linked a pull request Aug 28, 2020 that will close this issue
@ghost ghost closed this as completed in #5864 Aug 28, 2020
@JunielKatarn JunielKatarn reopened this Aug 28, 2020
@JunielKatarn
Copy link
Contributor Author

JunielKatarn commented Aug 28, 2020

Reopening, this issue was not meant to be fully closed by #5864.

We need to set the V8 (and Hermes?) story straight so we have no pending relevant dependencies.
See the checklist in the description.

@NickGerleman
Copy link
Collaborator

I believe this was completed. Please reopen if this wasn't.

@JunielKatarn
Copy link
Contributor Author

I believe this was completed. Please reopen if this wasn't.

See the Dependencies section in the description.

Those correspond to other projects. I leave it to your criteria if those should be considered into keeping a RNW issue open or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants