Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native upgrade-windows command #674

Closed
rozele opened this issue Sep 7, 2016 · 6 comments
Closed

Add react-native upgrade-windows command #674

rozele opened this issue Sep 7, 2016 · 6 comments
Assignees
Labels

Comments

@rozele
Copy link
Collaborator

rozele commented Sep 7, 2016

We're going to need something to re-run the yeoman generator (like react-native upgrade).

@rozele rozele added this to the Developer Experience milestone Sep 7, 2016
@rozele rozele added p2 labels Sep 7, 2016
@rozele rozele self-assigned this Oct 11, 2016
@achipa
Copy link

achipa commented Apr 9, 2018

Any progress/plan on this? The recent change in how Yoga is referenced was a good example why this can come handy (as opposed to manually mucking with templates and figuring out what/how has changed in csproj/sln templates)

@rozele
Copy link
Collaborator Author

rozele commented Apr 9, 2018

@achipa Thanks for pinging on this. I think the right solution is to build the right, stable project configuration hooks into react-native-windows so we don't have to deal with breaking changes. One such attempt was recently added in the 0.55 RC:
cdde4d7

The problem comes along with what projects need to be added to the .sln file, as this is not something you can "modularize". The "right" thing to do is to publish a compiled version of react-native-windows on NuGet so you don't need to include the projects in the solution, but realistically we're still a ways from that. There are many arguments to be made for building from source (many enterprises require it, we can guarantee we're using the same Yoga implementation across platforms, native debugging is easier, etc.)

@rozele
Copy link
Collaborator Author

rozele commented Apr 9, 2018

So, I think I've just convinced myself we need to bump the priority on this so we can easily support building from source :-)

@rozele
Copy link
Collaborator Author

rozele commented Apr 9, 2018

Not sure if this is a dupe or just related to #1358

@achipa
Copy link

achipa commented Apr 9, 2018

Related (two different implementation points for the same issue), in the sense that it's a separate project for upgrading the templates via git, whereas this issue describes it as part of react-native-windows.

I can think of arguments for both, so can't really say I have a preference (as long as there is a way to track these upgrades in at least a semi-automated fashion).

@rozele rozele added the .NET label Feb 26, 2019
@chrisglein chrisglein added the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost
Copy link

ghost commented Oct 25, 2019

We are not investing in new features or lower priority bug fixes on vCurrent. The bulk of investment is now in vNext as we prepare to make that the default choice. If this issue is still relevant on the vNext implementation please open a vNext issue. If this issue is of significant severity for a vCurrent app and vNext is not an option, re-open with justification.

@ghost ghost removed the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@chrisglein chrisglein added the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost ghost removed the .NET Archive Issue opened against deprecated .NET implementation, will be closed (label drives bot activity) label Oct 25, 2019
@ghost ghost closed this as completed Oct 25, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants