Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for C++ WinAppSDK apps (CLI template) #8132

Closed
Tracked by #9600
asklar opened this issue Jun 29, 2021 · 5 comments
Closed
Tracked by #9600

Support for C++ WinAppSDK apps (CLI template) #8132

asklar opened this issue Jun 29, 2021 · 5 comments

Comments

@asklar
Copy link
Member

asklar commented Jun 29, 2021

Current plan is to start with C#, so filing this to add a C++/WinRT Reunion template in the future

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 29, 2021
@chrisglein chrisglein added Area: WinUI and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jul 1, 2021
@chrisglein
Copy link
Member

We should start organizing this work into a project board so it's clear where to track progress on Windows App SDK support.

@chrisglein chrisglein added this to the 0.66 milestone Jul 1, 2021
@chrisglein chrisglein modified the milestones: 0.66, 0.67 Aug 31, 2021
@asklar asklar modified the milestones: 0.67, 0.68 Oct 22, 2021
@chrisglein
Copy link
Member

Notes from planning poker:

Install WinAppSDK, open a new project, and get RNW loading into that. Then reverse engineer the project template from that. From learnings on doing this for C#, can be 1-2 weeks. Will need to navigate PackageReference. C# had breaks due to the preview versions that we won't have to deal with here. How many #ifWinUI3 checks to we have to keep and maintain? There are many of these in aggregate that add cost.

@chrisglein chrisglein modified the milestones: 0.68, 0.69 Feb 18, 2022
@AgneLukoseviciute AgneLukoseviciute changed the title Support for C++ Reunion apps Support for C++ WinAppSDK apps Mar 9, 2022
@jonthysell
Copy link
Contributor

@AgneLukoseviciute Do you think this will make 0.69 or should it be moved to 0.70?

@AgneLukoseviciute
Copy link
Contributor

update: since we're moving in the direction of using NuGets instead of source, we'll want to create and publish a cpp WinAppSDK nuget -- aka Microsoft.ReactNative build with USE_WINUI3 defined. Next step here is to get a working NuGet generated (test through sample app).

@chrisglein chrisglein removed this from the 0.70 milestone Jul 18, 2022
@chrisglein chrisglein added this to the 0.71 milestone Jul 18, 2022
@asklar asklar changed the title Support for C++ WinAppSDK apps Support for C++ WinAppSDK apps (CLI template) Aug 11, 2022
@asklar asklar modified the milestones: 0.71, Backlog Aug 11, 2022
@AgneLukoseviciute AgneLukoseviciute removed their assignment Nov 2, 2022
@chrisglein
Copy link
Member

Back in late 2021 / early 2022 we started a WinAppSDK new app template based on understanding of WinAppSDK at the time. And then came Fabric and impact on our overall strategy for how to handle Win32/WinAppSDK. As such these original plans don't make as much sense and we'll be closing them as Not Planned. That's not in any way to say RNW isn't going to support WinAppSDK, we're just doing it differently! Track our Fabric progress for details on the new app template and how that'll be compatible with WinAppSDK.

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants