Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename / Rethink project creation flags for WinAppSDK #9711

Closed
Tracked by #9394
AgneLukoseviciute opened this issue Mar 17, 2022 · 3 comments
Closed
Tracked by #9394

Rename / Rethink project creation flags for WinAppSDK #9711

AgneLukoseviciute opened this issue Mar 17, 2022 · 3 comments
Labels
Area: CLI enhancement Needs: Dev Design Platform: WinAppSDK PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone

Comments

@AgneLukoseviciute
Copy link
Contributor

In the CLI, we currently distinguish between a UWP/WinUI2 app and WASDK/WinUI3 using the --winui3 flag. As support for more WinAppSDK configurations lands, we'll need a way to specify the kind of app that should be built in the CLI (unpackaged, MSIX packaged, WAP packaged). Proposed approach:


we should likely rename / rethink this flag [--usewinui3]. I think we'll want something like:
--projectTemplate which takes a value of one of: uwp, winappsk-single, winappsdk-wap, etc.

Originally posted by @asklar in #9177 (comment)


@AgneLukoseviciute AgneLukoseviciute self-assigned this Mar 17, 2022
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 17, 2022
@AgneLukoseviciute AgneLukoseviciute added the PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) label Mar 17, 2022
@chrisglein chrisglein added this to the Backlog milestone Mar 17, 2022
@chrisglein
Copy link
Member

@AgneLukoseviciute does this fit in one of the phases for WinAppSDK? If so can you link it to the correct issue? Is it #9394?

@chrisglein chrisglein added Needs: Dev Design Area: CLI and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 17, 2022
@chrisglein
Copy link
Member

Tricky aspect: This needs to work for all versions of RNW. So what we change it to needs to balance pre and post WinAppSDK.

@AgneLukoseviciute AgneLukoseviciute removed their assignment Nov 2, 2022
@TatianaKapos TatianaKapos added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 24, 2023
@chrisglein
Copy link
Member

Back in late 2021 / early 2022 we started a WinAppSDK new app template based on understanding of WinAppSDK at the time. And then came Fabric and impact on our overall strategy for how to handle Win32/WinAppSDK. As such these original plans don't make as much sense and we'll be closing them as Not Planned. That's not in any way to say RNW isn't going to support WinAppSDK, we're just doing it differently! Track our Fabric progress for details on the new app template and how that'll be compatible with WinAppSDK.

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CLI enhancement Needs: Dev Design Platform: WinAppSDK PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
None yet
Development

No branches or pull requests

3 participants