Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxContentSizeMultiplier prop not working on Text #1052

Open
jessamp opened this issue Mar 12, 2019 · 4 comments
Open

maxContentSizeMultiplier prop not working on Text #1052

jessamp opened this issue Mar 12, 2019 · 4 comments

Comments

@jessamp
Copy link

jessamp commented Mar 12, 2019

I tried to set the maxContentSizeMultiplier prop on a Text component, but it looks like it's not changing anything. React native has something similar to this called maxFontSizeMultiplier. Is this supposed to have the same behavior?

https://facebook.github.io/react-native/docs/text#maxfontsizemultiplier

@jessamp jessamp changed the title maxContentSizeMultiplier not working on Text maxContentSizeMultiplier prop not working on Text Mar 12, 2019
@erictraut
Copy link
Contributor

Yes, it looks like this functionality finally made it into RN, but it's under a different name than the one the Skype team initially used. See #783 for more details. We should change the ReactXP implementation accordingly. I'd prefer to stick with the "maxContentSizeMultiplier" name in the ReactXP interface to avoid a breaking change for ReactXP.

@jessamp
Copy link
Author

jessamp commented Mar 14, 2019

Yeah we've used those functions :).
When will this be available for public use? Or would it be helpful to submit a PR?

@fbartho fbartho added this to the 2.1.0 milestone Aug 9, 2020
@fbartho
Copy link
Contributor

fbartho commented Aug 9, 2020

@erictraut / @jessamp -- now that TypeScript supports the @deprecated feature (and VSCode Displays it!)

I think we could start providing the new API, and cross-map the old values to the new ones. What do you think?

@erictraut
Copy link
Contributor

Yeah, good suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants