-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxContentSizeMultiplier prop not working on Text #1052
Comments
Yes, it looks like this functionality finally made it into RN, but it's under a different name than the one the Skype team initially used. See #783 for more details. We should change the ReactXP implementation accordingly. I'd prefer to stick with the "maxContentSizeMultiplier" name in the ReactXP interface to avoid a breaking change for ReactXP. |
Yeah we've used those functions :). |
@erictraut / @jessamp -- now that TypeScript supports the I think we could start providing the new API, and cross-map the old values to the new ones. What do you think? |
Yeah, good suggestion. |
I tried to set the maxContentSizeMultiplier prop on a Text component, but it looks like it's not changing anything. React native has something similar to this called maxFontSizeMultiplier. Is this supposed to have the same behavior?
https://facebook.github.io/react-native/docs/text#maxfontsizemultiplier
The text was updated successfully, but these errors were encountered: