Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Restructure ReactXP as a lerna monorepo to facilitate testing internal projects #844

Open
luisnaranjo733 opened this issue Oct 7, 2018 · 3 comments
Assignees

Comments

@luisnaranjo733
Copy link
Member

luisnaranjo733 commented Oct 7, 2018

I think maintaining ReactXP would be easier if it were structured as a lerna monorepo.

Example scenario today:

  • You make a breaking change to the XP source
  • You want to add a test case to test your test project to test this change, but this project uses a published version of XP, so you can only test by manually building XP and copying the source over to node_modules.

Same scenario with a lerna monorepo

  • You make a breaking change
  • Changes will be automatically available in node_modules of the internal project because lerna bootstrap symlinks node_modules for you

For example, see this snippet from Wix's Detox framework contribution guide

For all the internal projects (detox, detox-cli, demos, test) lerna will create symbolic links in node_modules instead of npm copying the content of the projects. This way, any change you do on any code is there immediately. There is no need to update node modules or copy files between projects.

@luisnaranjo733 luisnaranjo733 changed the title [Suggestion] Restructure ReactXP as a lerna monorepo to facilitate internal projects [Suggestion] Restructure ReactXP as a lerna monorepo to facilitate testing internal projects Oct 7, 2018
@erictraut
Copy link
Contributor

I don't know if lerna is the answer, but I agree that this is a problem. Another potential solution is to have the RXPTest sample directly import from the core ReactXP sources rather than importing the published version.

@fbartho fbartho self-assigned this Aug 9, 2020
@fbartho
Copy link
Contributor

fbartho commented Aug 9, 2020

I'm motivated to get some sort of improved tooling for testing, but I think we can get that done with simpler tools than lerna.

Was there anything further you wanted to request in this ticket @luisnaranjo733 ?

See also #1233

@luisnaranjo733
Copy link
Member Author

Nope! My intent was to outline the problem, not to be prescriptive about the solution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants