You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think maintaining ReactXP would be easier if it were structured as a lerna monorepo.
Example scenario today:
You make a breaking change to the XP source
You want to add a test case to test your test project to test this change, but this project uses a published version of XP, so you can only test by manually building XP and copying the source over to node_modules.
Same scenario with a lerna monorepo
You make a breaking change
Changes will be automatically available in node_modules of the internal project because lerna bootstrap symlinks node_modules for you
For example, see this snippet from Wix's Detox framework contribution guide
For all the internal projects (detox, detox-cli, demos, test) lerna will create symbolic links in node_modules instead of npm copying the content of the projects. This way, any change you do on any code is there immediately. There is no need to update node modules or copy files between projects.
The text was updated successfully, but these errors were encountered:
luisnaranjo733
changed the title
[Suggestion] Restructure ReactXP as a lerna monorepo to facilitate internal projects
[Suggestion] Restructure ReactXP as a lerna monorepo to facilitate testing internal projects
Oct 7, 2018
I don't know if lerna is the answer, but I agree that this is a problem. Another potential solution is to have the RXPTest sample directly import from the core ReactXP sources rather than importing the published version.
I think maintaining ReactXP would be easier if it were structured as a lerna monorepo.
Example scenario today:
Same scenario with a lerna monorepo
lerna bootstrap
symlinks node_modules for youFor example, see this snippet from Wix's Detox framework contribution guide
The text was updated successfully, but these errors were encountered: