Clean up cyclic projects (#5184)

* Create a decoupled-local-node-rig project.

* fixup! Create a decoupled-local-node-rig project.

* Move the local eslint rules over to decoupled-local-node-rig.

* fixup! Move the local eslint rules over to decoupled-local-node-rig.

* fixup! Create a decoupled-local-node-rig project.

* Eliminate a lot of duplication due to cyclic dependencies.

* Rush update.

* Rush change.

Author: iclanton

README.md

@@ -200,6 +200,7 @@ These GitHub repositories provide supplementary resources for Rush Stack:
 | [/repo-scripts/doc-plugin-rush-stack](./repo-scripts/doc-plugin-rush-stack/) | API Documenter plugin used with the rushstack.io website |
 | [/repo-scripts/generate-api-docs](./repo-scripts/generate-api-docs/) | Used to generate API docs for the rushstack.io website |
 | [/repo-scripts/repo-toolbox](./repo-scripts/repo-toolbox/) | Used to execute various operations specific to this repo |
+| [/rigs/decoupled-local-node-rig](./rigs/decoupled-local-node-rig/) | A rig package for Node.js projects that build using Heft inside the RushStack repository, but are dependencies of @rushstack/heft-node-rig or local-node-rig. |
 | [/rigs/local-node-rig](./rigs/local-node-rig/) | A rig package for Node.js projects that build using Heft inside the RushStack repository. |
 | [/rigs/local-web-rig](./rigs/local-web-rig/) | A rig package for Web projects that build using Heft inside the RushStack repository. |
 | [/rush-plugins/rush-buildxl-graph-plugin](./rush-plugins/rush-buildxl-graph-plugin/) | Rush plugin for generating a BuildXL graph. |

apps/api-extractor/.eslintrc.js

@@ -1,10 +1,13 @@
 // This is a workaround for https://github.com/eslint/eslint/issues/3458
-require('local-eslint-config/patch/modern-module-resolution');
+require('decoupled-local-node-rig/profiles/default/includes/eslint/patch/modern-module-resolution');
 // This is a workaround for https://github.com/microsoft/rushstack/issues/3021
-require('local-eslint-config/patch/custom-config-package-names');
+require('decoupled-local-node-rig/profiles/default/includes/eslint/patch/custom-config-package-names');
 
 module.exports = {
-  extends: ['local-eslint-config/profile/node-trusted-tool', 'local-eslint-config/mixins/friendly-locals'],
+  extends: [
+    'decoupled-local-node-rig/profiles/default/includes/eslint/profile/node-trusted-tool',
+    'decoupled-local-node-rig/profiles/default/includes/eslint/mixins/friendly-locals'
+  ],
   parserOptions: { tsconfigRootDir: __dirname },
 
   overrides: [

apps/api-extractor/config/heft.json

@@ -8,7 +8,7 @@
    * Optionally specifies another JSON config file that this file extends from. This provides a way for standard
    * settings to be shared across multiple projects.
    */
-  "extends": "@rushstack/heft-node-rig/profiles/default/config/heft.json",
+  "extends": "decoupled-local-node-rig/profiles/default/config/heft.json",
 
   "phasesByName": {
     "build": {

apps/api-extractor/config/jest.config.json

@@ -1,11 +1,3 @@
 {
-  "extends": "@rushstack/heft-node-rig/profiles/default/config/jest.config.json",
-
-  // Enable code coverage for Jest
-  "collectCoverage": true,
-  "coverageDirectory": "<rootDir>/coverage",
-  "coverageReporters": ["cobertura", "html"],
-
-  // Use v8 coverage provider to avoid Babel
-  "coverageProvider": "v8"
+  "extends": "decoupled-local-node-rig/profiles/default/config/jest.config.json"
 }

apps/api-extractor/config/rig.json

@@ -3,5 +3,5 @@
   // Documentation for this system: https://www.npmjs.com/package/@rushstack/rig-package
   "$schema": "https://developer.microsoft.com/json-schemas/rig-package/rig.schema.json",
 
-  "rigPackageName": "@rushstack/heft-node-rig"
+  "rigPackageName": "decoupled-local-node-rig"
 }

apps/api-extractor/package.json

@@ -52,12 +52,10 @@
     "typescript": "5.8.2"
   },
   "devDependencies": {
-    "@rushstack/heft-node-rig": "2.8.0",
+    "decoupled-local-node-rig": "workspace:*",
     "@rushstack/heft": "0.70.0",
-    "@types/heft-jest": "1.0.1",
     "@types/lodash": "4.14.116",
     "@types/minimatch": "3.0.5",
-    "@types/node": "20.17.19",
     "@types/resolve": "1.20.2",
     "@types/semver": "7.5.0",
     "local-eslint-config": "workspace:*"

apps/api-extractor/tsconfig.json

@@ -1,9 +1,3 @@
 {
-  "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
-
-  "compilerOptions": {
-    "isolatedModules": true,
-    "types": ["heft-jest", "node"],
-    "resolveJsonModule": true
-  }
+  "extends": "./node_modules/decoupled-local-node-rig/profiles/default/tsconfig-base.json"
 }

apps/heft/config/jest.config.json

@@ -1,11 +1,3 @@
 {
-  "extends": "@rushstack/heft-node-rig/profiles/default/config/jest.config.json",
-
-  // Enable code coverage for Jest
-  "collectCoverage": true,
-  "coverageDirectory": "<rootDir>/coverage",
-  "coverageReporters": ["cobertura", "html"],
-
-  // Use v8 coverage provider to avoid Babel
-  "coverageProvider": "v8"
+  "extends": "decoupled-local-node-rig/profiles/default/config/jest.config.json"
 }

apps/heft/config/rig.json

@@ -3,5 +3,5 @@
   // Documentation for this system: https://www.npmjs.com/package/@rushstack/rig-package
   "$schema": "https://developer.microsoft.com/json-schemas/rig-package/rig.schema.json",
 
-  "rigPackageName": "@rushstack/heft-node-rig"
+  "rigPackageName": "decoupled-local-node-rig"
 }