Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heft] Fix an issue where heft would crash when copying static assets in --watch mode. #2557

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

iclanton
Copy link
Member

Summary

There is an issue where heft build --watch will crash when a file listed as a static asset to copy to the "lib" folder(s) is edited. This issue was introduced when support for automatically detecting the "lib" folder specified as the outDir in tsconfig.json was added. That path has to be resolved relative to the tsconfig.json file that specifies it, which may be a file specified in an "extends" property.

Details

This PR adds a resolvedDestinationFolderPaths property to the CopyFilesPlugin copy operation descriptor which is preemptively resolved to an absolute path.

How it was tested

Tested by building a large project containing .scss files both in --watch and not in --watch mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants