-
Notifications
You must be signed in to change notification settings - Fork 626
[heft] Migrate heft-webpack5-plugin to use webpack-dev-server@4.0.x #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
it looks like |
The missing typings might not be a huge issue, unless the API changed in nontrivial ways. Do you know if it changed? Is it enough to just bump the dependency version? |
@iclanton looks like there where some breaking changes, below a migration guide: The stable version just got release 2 days ago, but no type updates yet from DefinitelyTyped |
this issue is solved |
Uh oh!
There was an error while loading. Please reload this page.
Summary
heft-webpack5-plugin
binds towebpack-dev-server
3.11.x. It looks like 3.11.x currently only provides basic compatibility with webpack 5.0, as open issues are only being addressed in version 4.x.x.This ticket is a request to consider to update the dependency of
webpack-dev-server
inheft-webpack5-plugin
from@3.11.x
to@4.0.x
which provides official webpack 5 compatibility.As 4.x.x. includes breaking changes and just hit the RC.0 status an alternative could be to 'loosen' the semver binding of webpack-dev-server to allow major version overrides on a project/rig basis.
Repro steps
An example of a failure case of
webpack-dev-server
[3.11.x] is to handle es5 targets properly with HMR:target: ['web', 'es5']
Reference:
webpack/webpack-dev-server#2961
Standard questions
Please answer these questions to help us investigate your issue more quickly:
@rushstack/heft
version?node -v
)?The text was updated successfully, but these errors were encountered: