Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHelper: Allow client to explicitly set git.exe location #2105

Closed
ghost opened this issue Oct 12, 2020 · 2 comments · Fixed by #2110
Closed

GitHelper: Allow client to explicitly set git.exe location #2105

ghost opened this issue Oct 12, 2020 · 2 comments · Fixed by #2110
Assignees
@eddynaka
Labels
design-improvement

Comments

@ghost
Copy link

ghost commented Oct 12, 2020

No description provided.

@ghost ghost added the design-improvement label Oct 12, 2020
@eddynaka eddynaka self-assigned this Oct 12, 2020
@eddynaka
Copy link
Collaborator

@cfaucon @michaelcfanning , looking at the current GitHelper.cs, I thought in two options:

  • create an overload for the constructor
  • create a new method that enables the user to set the path

what do you think?

@eddynaka eddynaka mentioned this issue Oct 13, 2020
Merged
@eddynaka
Copy link
Collaborator

@cfaucon @michaelcfanning , based on the e-mail thread.

Just created a PR enabling the setter. That would solve the issue as well.

Let me know what do you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddynaka eddynaka

Labels
design-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding setter to GitExePath microsoft/sarif-sdk
1 participant
@eddynaka